LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-15 23:37:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibCrypto: Adjust DER length encoding to follow the spec

Browse Source 
It says to always use the smallest possible length representation
This commit is contained in:
stelar7 2024-03-22 10:10:41 +01:00 committed by Andrew Kaster
parent 2e142105c9
commit 1be411cc73
Notes: sideshowbarker 2024-07-17 09:56:35 +09:00 
Author: https://github.com/stelar7
Commit: https://github.com/SerenityOS/serenity/commit/1be411cc73
Pull-request: https://github.com/SerenityOS/serenity/pull/23674
Issue: https://github.com/SerenityOS/serenity/issues/23657
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibCrypto/ASN1/DER.cpp
View File

@ -262,7 +262,8 @@ ErrorOr<void> Encoder::write_length(size_t value)
if (value < 0x80)
return write_byte(value);
size_t size = ceil_div(AK::ceil_log2(value), 3ul);
size_t size_in_bits = AK::ceil_log2(value);
size_t size = ceil_div(size_in_bits, 8ul);
TRY(write_byte(0x80 | size));
for (size_t i = 0; i < size; i++) {