LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 17:27:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibAudio: Perform all seekpoint binary searches with comparisons

Browse Source 
One was missed in the previous fix
This commit is contained in:
kleines Filmröllchen 2023-08-19 20:51:37 +02:00 committed by Andrew Kaster
parent 2b61193b71
commit 1bf81f84a0
Notes: sideshowbarker 2024-07-17 09:56:35 +09:00 
Author: https://github.com/kleinesfilmroellchen
Commit: https://github.com/SerenityOS/serenity/commit/1bf81f84a0
Pull-request: https://github.com/SerenityOS/serenity/pull/20686
Reviewed-by: https://github.com/Hendiadyoin1
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibAudio/GenericTypes.cpp
View File

@ -51,7 +51,12 @@ Optional<u64> SeekTable::seek_point_sample_distance_around(u64 sample_index) con
return {};
size_t nearby_seek_point_index = 0;
AK::binary_search(m_seek_points, sample_index, &nearby_seek_point_index, [](auto const& sample_index, auto const& seekpoint_candidate) {
return static_cast<i64>(sample_index) - static_cast<i64>(seekpoint_candidate.sample_index);
// Subtraction with i64 cast may cause overflow.
if (sample_index > seekpoint_candidate.sample_index)
return 1;
if (sample_index == seekpoint_candidate.sample_index)
return 0;
return -1;
});
while (nearby_seek_point_index < m_seek_points.size() && m_seek_points[nearby_seek_point_index].sample_index <= sample_index)