LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibCpp: Fix parsing of ellipsis

Browse Source 
Previously the positional information for the node of an ellipsis was
incorrect.
This commit is contained in:
Itamar 2021-07-03 11:33:01 +03:00 committed by Andreas Kling
parent 55dd568583
commit 1dfdfcf820
Notes: sideshowbarker 2024-07-18 10:30:17 +09:00 
Author: https://github.com/itamar8910
Commit: https://github.com/SerenityOS/serenity/commit/1dfdfcf820d
Pull-request: https://github.com/SerenityOS/serenity/pull/8403
Reviewed-by: https://github.com/awesomekling
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Userland/Libraries/LibCpp/Parser.cpp
View File

@ -743,11 +743,12 @@ Optional<NonnullRefPtrVector<Parameter>> Parser::parse_parameter_list(ASTNode& p
NonnullRefPtrVector<Parameter> parameters;
while (peek().type() != Token::Type::RightParen && !eof()) {
if (match_ellipsis()) {
auto last_dot = consume();
while (peek().type() == Token::Type::Dot)
last_dot = consume();
auto param = create_ast_node<Parameter>(parent, position(), last_dot.end(), StringView {});
auto param = create_ast_node<Parameter>(parent, position(), {}, StringView {});
consume(Token::Type::Dot);
consume(Token::Type::Dot);
auto last_dot = consume(Token::Type::Dot);
param->m_is_ellipsis = true;
param->set_end(last_dot.end());
parameters.append(move(param));
} else {
auto type = parse_type(parent);
@ -1305,7 +1306,7 @@ bool Parser::match_ellipsis()
{
if (m_state.token_index > m_tokens.size() - 3)
return false;
return peek().type() == Token::Type::Dot && peek().type() == Token::Type::Dot && peek().type() == Token::Type::Dot;
return peek().type() == Token::Type::Dot && peek(1).type() == Token::Type::Dot && peek(2).type() == Token::Type::Dot;
}
void Parser::add_tokens_for_preprocessor(Token& replaced_token, Preprocessor::DefinedValue& definition)
{