LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-13 11:42:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "LibGUI: Only dispatch Leave if the now-hovered widget isn't a child"

Browse Source 
This reverts commit cfc9ee6f16.

This change was wrong: The parent *does* lose hover when the mouse
cursor enters a child widget. Hover is not hierarchical, there is only a
hovered window and a hovered widget within that window.

This fixes an issue with GUI::TabWidget buttons appearing hovered
despite the mouse cursor not being over the buttons.
This commit is contained in:
Andreas Kling 2021-07-28 21:24:29 +02:00
parent 230f7ce71c
commit 2135c66823
Notes: sideshowbarker 2024-07-18 07:58:43 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/2135c668235
3 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Userland/Libraries/LibGUI/Widget.cpp
View File

@ -1143,20 +1143,4 @@ bool Widget::is_visible_for_timer_purposes() const
return is_visible() && Object::is_visible_for_timer_purposes();
}
bool Widget::is_parent_of(Widget const* widget) const
{
if (widget == nullptr)
return false;
Widget const* current_widget = widget->parent_widget();
while (current_widget != nullptr) {
if (current_widget == this)
return true;
current_widget = current_widget->parent_widget();
}
return false;
}
}

2
Userland/Libraries/LibGUI/Widget.h
View File

@ -280,8 +280,6 @@ public:
bool has_pending_drop() const;
bool is_parent_of(Widget const*) const;
protected:
Widget();

2
Userland/Libraries/LibGUI/Window.cpp
View File

@ -802,7 +802,7 @@ void Window::set_hovered_widget(Widget* widget)
if (widget == m_hovered_widget)
return;
if (m_hovered_widget && !m_hovered_widget->is_parent_of(widget))
if (m_hovered_widget)
Core::EventLoop::current().post_event(*m_hovered_widget, make<Event>(Event::Leave));
m_hovered_widget = widget;