LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-11 09:18:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibRegex: Avoid making unnecessary string copies

Browse Source
This commit is contained in:
Gunnar Beutner 2021-06-13 22:30:02 +02:00 committed by Ali Mohammad Pur
parent 281f39073d
commit 214410b397
Notes: sideshowbarker 2024-07-18 12:15:28 +09:00 
Author: https://github.com/gunnarbeutner
Commit: https://github.com/SerenityOS/serenity/commit/214410b3979
Pull-request: https://github.com/SerenityOS/serenity/pull/8044
Reviewed-by: https://github.com/alimpfard
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Userland/Libraries/LibRegex/RegexByteCode.cpp
View File

@ -528,15 +528,13 @@ ALWAYS_INLINE bool OpCode_Compare::compare_string(const MatchInput& input, Match
auto str_view1 = StringView(str, length);
auto str_view2 = StringView(&input.view.u8view()[state.string_position], length);
String str1, str2;
if (input.regex_options & AllFlags::Insensitive) {
str1 = str_view1.to_string().to_lowercase();
str2 = str_view2.to_string().to_lowercase();
str_view1 = str1.view();
str_view2 = str2.view();
}
bool string_equals;
if (input.regex_options & AllFlags::Insensitive)
string_equals = str_view1.equals_ignoring_case(str_view2);
else
string_equals = str_view1 == str_view2;
if (str_view1 == str_view2) {
if (string_equals) {
state.string_position += length;
if (length == 0)
had_zero_length_match = true;