LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibPDF: Add two FIXMEs

Browse Source
This commit is contained in:
Nico Weber 2023-10-12 10:18:46 -04:00 committed by Andreas Kling
parent d451197d3d
commit 2249e79630
Notes: sideshowbarker 2024-07-17 08:55:54 +09:00 
Author: https://github.com/nico
Commit: https://github.com/SerenityOS/serenity/commit/2249e79630
Pull-request: https://github.com/SerenityOS/serenity/pull/21427
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibPDF/Encoding.cpp
View File

@ -23,6 +23,9 @@ PDFErrorOr<NonnullRefPtr<Encoding>> Encoding::from_object(Document* document, No
auto name = obj->cast<NameObject>()->name();
if (name == "StandardEncoding")
return standard_encoding();
// FIXME: MacExpertEncoding
if (name == "MacRomanEncoding")
return mac_encoding();
if (name == "WinAnsiEncoding")

1
Userland/Libraries/LibPDF/Fonts/CFF.cpp
View File

@ -388,6 +388,7 @@ PDFErrorOr<Vector<DeprecatedFlyString>> CFF::parse_charset(Reader&& reader, size
auto resolve = [](SID sid) {
if (sid < s_cff_builtin_names.size())
return DeprecatedFlyString(s_cff_builtin_names[sid]);
// FIXME: Read from String INDEX instead.
dbgln("Cound't find string for SID {}, going with space", sid);
return DeprecatedFlyString("space");
};