LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 10:19:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Implement Temporal.PlainDateTime.prototype.withPlainTime()

Browse Source
This commit is contained in:
Idan Horowitz 2021-08-27 19:05:16 +03:00 committed by Linus Groh
parent 0f464f38d3
commit 24dbf18936
Notes: sideshowbarker 2024-07-18 05:13:01 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/24dbf189369
Pull-request: https://github.com/SerenityOS/serenity/pull/9641
Reviewed-by: https://github.com/linusg ✅
4 changed files with 47 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
View File

@ -437,6 +437,7 @@ namespace JS {
P(with) \
P(withCalendar) \
P(withPlainDate) \
P(withPlainTime) \
P(writable) \
P(year) \
P(yearMonthFromFields) \

25
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.cpp
View File

@ -51,6 +51,7 @@ void PlainDateTimePrototype::initialize(GlobalObject& global_object)
define_native_accessor(vm.names.inLeapYear, in_leap_year_getter, {}, Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.withPlainTime, with_plain_time, 1, attr);
define_native_function(vm.names.withPlainDate, with_plain_date, 1, attr);
define_native_function(vm.names.withCalendar, with_calendar, 1, attr);
define_native_function(vm.names.equals, equals, 1, attr);
@ -358,6 +359,30 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::in_leap_year_getter)
return calendar_in_leap_year(global_object, calendar, *date_time);
}
// 5.3.23 Temporal.PlainDateTime.prototype.withPlainTime ( [ plainTimeLike ] ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaintime
JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::with_plain_time)
{
// 1. Let dateTime be the this value.
// 2. Perform ? RequireInternalSlot(dateTime, [[InitializedTemporalDateTime]]).
auto* date_time = typed_this(global_object);
if (vm.exception())
return {};
// 3. If plainTimeLike is undefined, then
if (vm.argument(0).is_undefined()) {
// a. Return ? CreateTemporalDateTime(dateTime.[[ISOYear]], dateTime.[[ISOMonth]], dateTime.[[ISODay]], 0, 0, 0, 0, 0, 0, dateTime.[[Calendar]]).
return create_temporal_date_time(global_object, date_time->iso_year(), date_time->iso_month(), date_time->iso_day(), 0, 0, 0, 0, 0, 0, date_time->calendar());
}
// 4. Let plainTime be ? ToTemporalTime(plainTimeLike).
auto* plain_time = to_temporal_time(global_object, vm.argument(0));
if (vm.exception())
return {};
// 5. Return ? CreateTemporalDateTime(dateTime.[[ISOYear]], dateTime.[[ISOMonth]], dateTime.[[ISODay]], plainTime.[[ISOHour]], plainTime.[[ISOMinute]], plainTime.[[ISOSecond]], plainTime.[[ISOMillisecond]], plainTime.[[ISOMicrosecond]], plainTime.[[ISONanosecond]], dateTime.[[Calendar]]).
return create_temporal_date_time(global_object, date_time->iso_year(), date_time->iso_month(), date_time->iso_day(), plain_time->iso_hour(), plain_time->iso_minute(), plain_time->iso_second(), plain_time->iso_millisecond(), plain_time->iso_microsecond(), plain_time->iso_nanosecond(), date_time->calendar());
}
// 5.3.24 Temporal.PlainDateTime.prototype.withPlainDate ( plainDateLike ), https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.withplaindate
JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::with_plain_date)
{

1
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.h
View File

@ -38,6 +38,7 @@ private:
JS_DECLARE_NATIVE_FUNCTION(days_in_year_getter);
JS_DECLARE_NATIVE_FUNCTION(months_in_year_getter);
JS_DECLARE_NATIVE_FUNCTION(in_leap_year_getter);
JS_DECLARE_NATIVE_FUNCTION(with_plain_time);
JS_DECLARE_NATIVE_FUNCTION(with_plain_date);
JS_DECLARE_NATIVE_FUNCTION(with_calendar);
JS_DECLARE_NATIVE_FUNCTION(equals);

20
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.prototype.withPlainTime.js Normal file
View File

@ -0,0 +1,20 @@
describe("correct behavior", () => {
test("length is 1", () => {
expect(Temporal.PlainDateTime.prototype.withPlainTime).toHaveLength(1);
});
test("basic functionality", () => {
const firstPlainDateTime = new Temporal.PlainDateTime(1, 2, 3, 4, 5, 6, 7, 8, 9);
const plainTime = new Temporal.PlainTime(10, 11, 12, 13, 14, 15);
const secondPlainDateTime = firstPlainDateTime.withPlainTime(plainTime);
expect(secondPlainDateTime.year).toBe(1);
expect(secondPlainDateTime.month).toBe(2);
expect(secondPlainDateTime.day).toBe(3);
expect(secondPlainDateTime.hour).toBe(10);
expect(secondPlainDateTime.minute).toBe(11);
expect(secondPlainDateTime.second).toBe(12);
expect(secondPlainDateTime.millisecond).toBe(13);
expect(secondPlainDateTime.microsecond).toBe(14);
expect(secondPlainDateTime.nanosecond).toBe(15);
});
});