LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-17 09:20:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibCore: Null-check struct addrinfo to avoid freeaddrinfo(NULL)

Browse Source 
On some C libraries, like NetBSD and musl-libc, this under-specified
edge case results in a crash rather than silently ignoring the null
pointer.
This commit is contained in:
Andrew Kaster 2024-05-09 15:13:48 -06:00 committed by Andrew Kaster
parent b5a60c0f9f
commit 2770b7eecd
Notes: sideshowbarker 2024-07-17 04:01:41 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/2770b7eecd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/82
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibCore/System.h
View File

@ -264,7 +264,11 @@ private:
}
struct AddrInfoDeleter {
void operator()(struct addrinfo* ptr) { ::freeaddrinfo(ptr); }
void operator()(struct addrinfo* ptr)
{
if (ptr)
::freeaddrinfo(ptr);
}
};
Vector<struct addrinfo> m_addresses {};