LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-17 01:10:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

Meta: Suppress PVS Studio Rule v591 "non-void functions should return"

Browse Source 
This rule appears to be fundamentally broken for our code base, it
flags `void` functions all over the place, as well as constructors.

Lets suppress it for now.
This commit is contained in:
Brian Gianforcaro 2022-04-03 15:41:49 -07:00 committed by Brian Gianforcaro
parent d749ea3b70
commit 2afcd45299
Notes: sideshowbarker 2024-07-17 14:29:00 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/2afcd45299
Pull-request: https://github.com/SerenityOS/serenity/pull/13494
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/pvs-studio-static-analysis.yml vendored
View File

@ -106,11 +106,12 @@ jobs:
# - False positives:
# V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference.
# V1076 Code contains invisible characters that may alter its logic.
# V591 Non-void function should return a value.
#
- name: Filter PVS Log
working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }}
run: |
pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 project.plog
pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 -v1076 -v591 project.plog
pvs-studio-analyzer filter-suppressed project.plog
- name: Print PVS Log