LibJS: Implement Atomics.and

This commit is contained in:
Timothy Flynn 2021-07-11 14:10:43 -04:00 committed by Linus Groh
parent 940875c9fd
commit 2d3af5c1b4
Notes: sideshowbarker 2024-07-18 09:02:21 +09:00
4 changed files with 91 additions and 0 deletions

View File

@ -118,6 +118,7 @@ void AtomicsObject::initialize(GlobalObject& global_object)
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.add, add, 3, attr);
define_native_function(vm.names.and_, and_, 3, attr);
define_native_function(vm.names.load, load, 2, attr);
// 25.4.15 Atomics [ @@toStringTag ], https://tc39.es/ecma262/#sec-atomics-@@tostringtag
@ -142,6 +143,24 @@ JS_DEFINE_NATIVE_FUNCTION(AtomicsObject::add)
VERIFY_NOT_REACHED();
}
// 25.4.4 Atomics.and ( typedArray, index, value ), https://tc39.es/ecma262/#sec-atomics.and
JS_DEFINE_NATIVE_FUNCTION(AtomicsObject::and_)
{
auto* typed_array = typed_array_from(global_object, vm.argument(0));
if (!typed_array)
return {};
auto atomic_and = [](auto* storage, auto value) { return AK::atomic_fetch_and(storage, value); };
#define __JS_ENUMERATE(ClassName, snake_name, PrototypeName, ConstructorName, Type) \
if (is<ClassName>(typed_array)) \
return perform_atomic_operation<Type>(global_object, *typed_array, move(atomic_and));
JS_ENUMERATE_TYPED_ARRAYS
#undef __JS_ENUMERATE
VERIFY_NOT_REACHED();
}
// 25.4.8 Atomics.load ( typedArray, index ), https://tc39.es/ecma262/#sec-atomics.load
JS_DEFINE_NATIVE_FUNCTION(AtomicsObject::load)
{

View File

@ -20,6 +20,7 @@ public:
private:
JS_DECLARE_NATIVE_FUNCTION(add);
JS_DECLARE_NATIVE_FUNCTION(and_);
JS_DECLARE_NATIVE_FUNCTION(load);
};

View File

@ -351,6 +351,7 @@ namespace JS {
P(writable)
struct CommonPropertyNames {
PropertyName and_ { "and", PropertyName::StringMayBeNumber::No };
PropertyName catch_ { "catch", PropertyName::StringMayBeNumber::No };
PropertyName delete_ { "delete", PropertyName::StringMayBeNumber::No };
PropertyName for_ { "for", PropertyName::StringMayBeNumber::No };

View File

@ -0,0 +1,70 @@
test("invariants", () => {
expect(Atomics.and).toHaveLength(3);
});
test("error cases", () => {
expect(() => {
Atomics.and("not an array", 0, 1);
}).toThrow(TypeError);
expect(() => {
const bad_array_type = new Float32Array(4);
Atomics.and(bad_array_type, 0, 1);
}).toThrow(TypeError);
expect(() => {
const bad_array_type = new Uint8ClampedArray(4);
Atomics.and(bad_array_type, 0, 1);
}).toThrow(TypeError);
expect(() => {
const array = new Int32Array(4);
Atomics.and(array, 100, 1);
}).toThrow(RangeError);
});
test("basic functionality (non-BigInt)", () => {
[Int8Array, Int16Array, Int32Array, Uint8Array, Uint16Array, Uint32Array].forEach(ArrayType => {
const array = new ArrayType(2);
array[0] = 0b0000;
array[1] = 0b0101;
expect(Atomics.and(array, 0, 0b0000)).toBe(0b0000);
expect(array).toEqual([0b0000, 0b0101]);
expect(Atomics.and(array, 0, 0b1111)).toBe(0b0000);
expect(array).toEqual([0b0000, 0b0101]);
expect(Atomics.and(array, 1, 0b0101)).toBe(0b0101);
expect(array).toEqual([0b0000, 0b0101]);
expect(Atomics.and(array, 1, 0b0100)).toBe(0b0101);
expect(array).toEqual([0b0000, 0b0100]);
expect(Atomics.and(array, 1, 0b0000)).toBe(0b0100);
expect(array).toEqual([0b0000, 0b0000]);
});
});
test("basic functionality (BigInt)", () => {
[BigInt64Array, BigUint64Array].forEach(ArrayType => {
const array = new ArrayType(2);
array[0] = 0b0000n;
array[1] = 0b0101n;
expect(Atomics.and(array, 0, 0b0000n)).toBe(0b0000n);
expect(array).toEqual([0b0000n, 0b0101n]);
expect(Atomics.and(array, 0, 0b1111n)).toBe(0b0000n);
expect(array).toEqual([0b0000n, 0b0101n]);
expect(Atomics.and(array, 1, 0b0101n)).toBe(0b0101n);
expect(array).toEqual([0b0000n, 0b0101n]);
expect(Atomics.and(array, 1, 0b0100n)).toBe(0b0101n);
expect(array).toEqual([0b0000n, 0b0100n]);
expect(Atomics.and(array, 1, 0b0000n)).toBe(0b0100n);
expect(array).toEqual([0b0000n, 0b0000n]);
});
});