LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-08 20:32:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Correct SetMutableBinding fallibility bug in spec comment

Browse Source 
This is an editorial change in the ECMA-262 spec.

See: https://github.com/tc39/ecma262/commit/656f0cf
This commit is contained in:
Linus Groh 2022-05-05 09:28:08 +02:00
parent 272cf3cbd5
commit 2fc9481bb6
Notes: sideshowbarker 2024-07-17 22:41:14 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/2fc9481bb6
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/GlobalEnvironment.cpp
View File

@ -97,9 +97,7 @@ ThrowCompletionOr<void> GlobalEnvironment::set_mutable_binding(GlobalObject& glo
// 1. Let DclRec be envRec.[[DeclarativeRecord]].
// 2. If ! DclRec.HasBinding(N) is true, then
if (MUST(m_declarative_record->has_binding(name))) {
// a. Return ! DclRec.SetMutableBinding(N, V, S).
// FIXME: Using MUST here breaks 22 tests in test262 (spec issue).
// Example: `function f() { x = 1; } f(); let x;`
// a. Return ? DclRec.SetMutableBinding(N, V, S).
return m_declarative_record->set_mutable_binding(global_object, name, value, strict);
}