mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-20 17:58:18 +03:00
LibVT: Properly populate context menu with open actions
We would previously overwrite m_hovered_href with tooltip texts instead of leaving it as an url as was expected by the context menu event handler.
This commit is contained in:
parent
17f5eb558c
commit
3052c0578c
Notes:
sideshowbarker
2024-07-17 18:38:25 +09:00
Author: https://github.com/networkException Commit: https://github.com/SerenityOS/serenity/commit/3052c0578c Pull-request: https://github.com/SerenityOS/serenity/pull/12600 Reviewed-by: https://github.com/kleinesfilmroellchen ✅
@ -827,23 +827,21 @@ void TerminalWidget::mousemove_event(GUI::MouseEvent& event)
|
||||
if (attribute.href_id != m_hovered_href_id) {
|
||||
if (m_active_href_id.is_null() || m_active_href_id == attribute.href_id) {
|
||||
m_hovered_href_id = attribute.href_id;
|
||||
m_hovered_href = attribute.href;
|
||||
|
||||
auto handlers = Desktop::Launcher::get_handlers_for_url(attribute.href);
|
||||
if (!handlers.is_empty()) {
|
||||
auto path = URL(attribute.href).path();
|
||||
auto name = LexicalPath::basename(path);
|
||||
if (path == handlers[0]) {
|
||||
m_hovered_href = String::formatted("Execute {}", name);
|
||||
} else {
|
||||
m_hovered_href = String::formatted("Open {} with {}", name, LexicalPath::basename(handlers[0]));
|
||||
}
|
||||
} else {
|
||||
m_hovered_href = attribute.href;
|
||||
if (path == handlers[0])
|
||||
set_tooltip(String::formatted("Execute {}", name));
|
||||
else
|
||||
set_tooltip(String::formatted("Open {} with {}", name, LexicalPath::basename(handlers[0])));
|
||||
}
|
||||
} else {
|
||||
m_hovered_href_id = {};
|
||||
m_hovered_href = {};
|
||||
}
|
||||
set_tooltip(m_hovered_href);
|
||||
show_or_hide_tooltip();
|
||||
if (!m_hovered_href.is_empty())
|
||||
set_override_cursor(Gfx::StandardCursor::Arrow);
|
||||
|
Loading…
Reference in New Issue
Block a user