LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-17 16:28:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWebView: Do not update cookie access time when fetched with WebDriver

Browse Source 
When WebDriver accesses cookies, it specifically says to run:

    the first step of the algorithm in RFC6265 to compute cookie-string

So we should skip subsequent steps. We already skip step 2, which sorts
the cookies, but neglected to skip step 3 to update their last access
time.
This commit is contained in:
Timothy Flynn 2024-04-21 10:25:51 -04:00 committed by Tim Flynn
parent 193fc7ef98
commit 306041f4ac
Notes: sideshowbarker 2024-07-17 18:08:55 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/306041f4ac
Pull-request: https://github.com/SerenityOS/serenity/pull/24057
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWebView/CookieJar.cpp
View File

@ -447,6 +447,10 @@ Vector<Web::Cookie::Cookie> CookieJar::get_matching_cookies(const URL::URL& url,
});
});
// NOTE: The WebDriver spec expects only step 1 above to be executed to match cookies.
if (mode == MatchingCookiesSpecMode::WebDriver)
return cookie_list;
// 3. Update the last-access-time of each cookie in the cookie-list to the current date and time.
auto now = UnixDateTime::now();