LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-06 02:55:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

Shell: Run function declarations in the current process

Browse Source 
Fixes #4817
This commit is contained in:
AnotherTest 2021-01-06 16:23:28 +03:30 committed by Andreas Kling
parent 81c5b35dce
commit 335221d830
Notes: sideshowbarker 2024-07-19 00:04:21 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/335221d830d
Pull-request: https://github.com/SerenityOS/serenity/pull/4824
Issue: https://github.com/SerenityOS/serenity/issues/4817
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Shell/AST.h
View File

@ -429,6 +429,7 @@ public:
virtual bool is_list() const { return false; }
virtual bool would_execute() const { return false; }
virtual bool should_override_execution_in_current_process() const { return false; }
const Position& position() const { return m_position; }
void set_is_syntax_error(const SyntaxError& error_node)
@ -829,6 +830,7 @@ private:
virtual HitTestResult hit_test_position(size_t) override;
virtual Vector<Line::CompletionSuggestion> complete_for_editor(Shell&, size_t, const HitTestResult&) override;
virtual bool would_execute() const override { return true; }
virtual bool should_override_execution_in_current_process() const override { return true; }
NameWithPosition m_name;
Vector<NameWithPosition> m_arguments;

6
Shell/Shell.cpp
View File

@ -729,6 +729,12 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
}
}
if (command.argv.is_empty() && !command.next_chain.is_empty() && command.should_immediately_execute_next && command.next_chain.first().node->should_override_execution_in_current_process()) {
for (auto& next_in_chain : command.next_chain)
run_tail(command, next_in_chain, last_return_code);
return nullptr;
}
Vector<const char*> argv;
Vector<String> copy_argv = command.argv;
argv.ensure_capacity(command.argv.size() + 1);