LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-29 06:02:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

CrashReporter: Show arguments and environment

Browse Source 
Arguments as a simple label, environment in a new tab. :^)

Closes #4779.
This commit is contained in:
Linus Groh 2021-01-15 20:51:52 +01:00 committed by Andreas Kling
parent 0187fd4fdd
commit 33c31e2198
Notes: sideshowbarker 2024-07-18 23:47:23 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/33c31e2198d
Pull-request: https://github.com/SerenityOS/serenity/pull/4963
2 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Userland/Applications/CrashReporter/CrashReporterWindow.gml
View File

@ -58,6 +58,24 @@
} }
} }
@GUI::Widget {
fixed_height: 18
layout: @GUI::HorizontalBoxLayout {
}
@GUI::Label {
text: "Arguments:"
text_alignment: "CenterLeft"
fixed_width: 90
}
@GUI::Label {
name: "arguments_label"
text_alignment: "CenterLeft"
}
}
@GUI::TabWidget { @GUI::TabWidget {
name: "tab_widget" name: "tab_widget"
} }

16
Userland/Applications/CrashReporter/main.cpp
View File

@ -105,6 +105,8 @@ int main(int argc, char** argv)
Vector<TitleAndText> thread_backtraces; Vector<TitleAndText> thread_backtraces;
String executable_path; String executable_path;
Vector<String> arguments;
Vector<String> environment;
int pid { 0 }; int pid { 0 };
u8 termination_signal { 0 }; u8 termination_signal { 0 };
@ -123,6 +125,8 @@ int main(int argc, char** argv)
}); });
executable_path = coredump->process_executable_path(); executable_path = coredump->process_executable_path();
arguments = coredump->process_arguments();
environment = coredump->process_environment();
pid = coredump->process_pid(); pid = coredump->process_pid();
termination_signal = coredump->process_termination_signal(); termination_signal = coredump->process_termination_signal();
} }
@ -188,6 +192,9 @@ int main(int argc, char** argv)
Desktop::Launcher::open(URL::create_with_file_protocol(LexicalPath(coredump_path).dirname())); Desktop::Launcher::open(URL::create_with_file_protocol(LexicalPath(coredump_path).dirname()));
}; };
auto& arguments_label = *widget.find_descendant_of_type_named<GUI::Label>("arguments_label");
arguments_label.set_text(String::join(" ", arguments));
auto& tab_widget = *widget.find_descendant_of_type_named<GUI::TabWidget>("tab_widget"); auto& tab_widget = *widget.find_descendant_of_type_named<GUI::TabWidget>("tab_widget");
auto& backtrace_tab = tab_widget.add_tab<GUI::Widget>("Backtrace"); auto& backtrace_tab = tab_widget.add_tab<GUI::Widget>("Backtrace");
@ -209,6 +216,15 @@ int main(int argc, char** argv)
backtrace_text_editor.set_should_hide_unnecessary_scrollbars(true); backtrace_text_editor.set_should_hide_unnecessary_scrollbars(true);
} }
auto& environment_tab = tab_widget.add_tab<GUI::Widget>("Environment");
environment_tab.set_layout<GUI::VerticalBoxLayout>();
environment_tab.layout()->set_margins({ 4, 4, 4, 4 });
auto& environment_text_editor = environment_tab.add<GUI::TextEditor>();
environment_text_editor.set_text(String::join("\n", environment));
environment_text_editor.set_mode(GUI::TextEditor::Mode::ReadOnly);
environment_text_editor.set_should_hide_unnecessary_scrollbars(true);
auto& close_button = *widget.find_descendant_of_type_named<GUI::Button>("close_button"); auto& close_button = *widget.find_descendant_of_type_named<GUI::Button>("close_button");
close_button.on_click = [&](auto) { close_button.on_click = [&](auto) {
app->quit(); app->quit();