LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

AK: Make explode_byte depend on sizeof(FlatPtr) instead of ARCH(...)

Browse Source 
The assumption that FlatPtr is 64-bit on every platform except i686 is
not correct, and also makes the definition of explode_byte() less nice
to look at.
This commit is contained in:
Ali Mohammad Pur 2021-08-23 13:07:22 +04:30 committed by Andreas Kling
parent a6fc80f069
commit 355c2eef57
Notes: sideshowbarker 2024-07-18 05:16:11 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/355c2eef570
Pull-request: https://github.com/SerenityOS/serenity/pull/9581
Reviewed-by: https://github.com/Dexesttp
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
AK/Types.h
View File

@ -67,22 +67,16 @@ using nullptr_t = decltype(nullptr);
static constexpr FlatPtr explode_byte(u8 b) static constexpr FlatPtr explode_byte(u8 b)
{ {
#if ARCH(I386) FlatPtr value = b;
return (u32)b << 24 | (u32)b << 16 | (u32)b << 8 | (u32)b; if constexpr (sizeof(FlatPtr) == 4)
#else return value << 24 | value << 16 | value << 8 | value;
return (u64)b << 56 | (u64)b << 48 | (u64)b << 40 | (u64)b << 32 | (u64)b << 24 | (u64)b << 16 | (u64)b << 8 | (u64)b; else if (sizeof(FlatPtr) == 8)
#endif return value << 56 | value << 48 | value << 40 | value << 32 | value << 24 | value << 16 | value << 8 | value;
} }
#if ARCH(I386) static_assert(explode_byte(0xff) == (FlatPtr)0xffffffffffffffffull);
static_assert(explode_byte(0xff) == 0xffffffff); static_assert(explode_byte(0x80) == (FlatPtr)0x8080808080808080ull);
static_assert(explode_byte(0x80) == 0x80808080); static_assert(explode_byte(0x7f) == (FlatPtr)0x7f7f7f7f7f7f7f7full);
static_assert(explode_byte(0x7f) == 0x7f7f7f7f);
#else
static_assert(explode_byte(0xff) == 0xffffffffffffffff);
static_assert(explode_byte(0x80) == 0x8080808080808080);
static_assert(explode_byte(0x7f) == 0x7f7f7f7f7f7f7f7f);
#endif
static_assert(explode_byte(0) == 0); static_assert(explode_byte(0) == 0);
constexpr size_t align_up_to(const size_t value, const size_t alignment) constexpr size_t align_up_to(const size_t value, const size_t alignment)