LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 01:37:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibC+Tests: Add extra tests for special values for strtod

Browse Source
This commit is contained in:
davidot 2022-10-12 02:10:48 +02:00 committed by Linus Groh
parent 1986b8b066
commit 35e52f7bfd
Notes: sideshowbarker 2024-07-17 05:12:05 +09:00 
Author: https://github.com/davidot
Commit: https://github.com/SerenityOS/serenity/commit/35e52f7bfd
Pull-request: https://github.com/SerenityOS/serenity/pull/15377
Issue: https://github.com/SerenityOS/serenity/issues/14691
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/linusg
1 changed files with 95 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
Tests/LibC/TestStrtodAccuracy.cpp
View File

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
* Copyright (c) 2022, David Tuin <davidot@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -223,10 +224,25 @@ static Testcase TESTCASES[] = {
{ "C80", -1, "4025cccccccccccd", "10.900000000000000012345678912345678912345" },
// Hexadecimal floats.
// Note that "0x579a" is "0xabcd << 1" with the top bit cut off, just as expected.
{ "Fp1", -1, "7c2579a000000000", "0xab.cdpef" },
// Hex floats do not allow hexadecimal digits in the exponent
{ "Fp1.1", 7, "406579a000000000", "0xab.cdpef" },
{ "Fp1.1", 7, "406579a000000000", "0xab.cdp-ef" },
{ "Fp1.1", 7, "406579a000000000", "0xab.cdpe-f" },
{ "Fp1.1", 7, "406579a000000000", "0xab.cdpef-" },
{ "Fp1.2", 11, "7c9579a000000000", "0xab.cdp963" },
{ "Fp1.3", 12, "7c9579a000000000", "0xab.cdp+963" },
{ "Fp1.4", 12, "7c2579a000000000", "0xab.cdp+956" },
{ "Fp1.4", 12, "7c1579a000000000", "0xab.cdp+955" },
{ "Fp1.5", 12, "04a579a000000000", "0xab.cdp-956" },
// Sneaky floating point :P
{ "Fp2", -1, "43e9400000000000", "0xCAPE" },
{ "Fp2.1", 4, "4069400000000000", "0xCAPE" },
{ "Fp2.1", 4, "4069400000000000", "0xCAP-E" },
{ "Fp2.2", 6, "4069400000000000", "0xCAP0" },
{ "Fp2.2", 7, "4069400000000000", "0xCAP+0" },
{ "Fp2.2", 7, "4069400000000000", "0xCAP-0" },
{ "Fp2.3", 7, "4159400000000000", "0xCAP15" },
{ "Fp2.4", 7, "4459400000000000", "0xCAP63" },
{ "Fp2.5", 7, "43e9400000000000", "0xCAP56" },
};
constexpr size_t NUM_TESTCASES = sizeof(TESTCASES) / sizeof(TESTCASES[0]);
@ -355,3 +371,79 @@ TEST_CASE(strtod_accuracy)
outln("PASS (with leniency up to {} ULP from the exact solution)", LENIENCY);
}
TEST_CASE(test_strtod_sets_errno)
{
#define EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO_BASE(str_value, double_value) \
do { \
errno = 0; \
auto value = strtod(str_value, nullptr); \
EXPECT_EQ(errno, 0); \
EXPECT_EQ(bit_cast<u64>(value), bit_cast<u64>(static_cast<double>(double_value))); \
} while (false)
#define EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO(str_value, double_value) \
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO_BASE(str_value, double_value); \
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO_BASE(" " str_value, double_value); \
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO_BASE("\t" str_value, double_value); \
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO_BASE("\n" str_value, double_value)
// Leading zeros are allowed
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("00", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("000", 0.);
// FIXME: Verify we only parse up to the appropriate point
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0xT", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0xp20", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x.t", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x.pt", 0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x1.p0", 1.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x1.pa", 1.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x.1pa", 0x0.1p0);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("0x.fpa", 0x0.fp0);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0xT", -0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0xp20", -0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x.t", -0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x.pt", -0.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x1.p0", -1.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x1.pa", -1.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x.1pa", -0x0.1p0);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-0x.fpa", -0x0.fp0);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("1", 1.);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("10e10", 10e10);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("10.10e10", 10.10e10);
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("inf", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("infinity", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("INF", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("INFINITY", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("Inf", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("iNf", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("inF", __builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-inf", -__builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-infinity", -__builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-INF", -__builtin_huge_val());
EXPECT_TO_GIVE_VALUE_WITH_0_ERRNO("-INFINITY", -__builtin_huge_val());
#define EXPECT_TO_GIVE_VALUE_WITH_ERRNO(str_value, double_value, errno_value) \
do { \
errno = 0; \
auto value = strtod(str_value, nullptr); \
EXPECT_EQ(errno, errno_value); \
EXPECT_EQ(bit_cast<u64>(value), bit_cast<u64>(static_cast<double>(double_value))); \
} while (false)
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("nan", __builtin_nan(""), ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("10e10000", __builtin_huge_val(), ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("0x1p10000", __builtin_huge_val(), ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("-10e10000", -__builtin_huge_val(), ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("-0x1p10000", -__builtin_huge_val(), ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("10e-10000", 0, ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("0x1p-10000", 0, ERANGE);
EXPECT_TO_GIVE_VALUE_WITH_ERRNO("-0x1p-10000", -0., ERANGE);
}