LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Use undefined as the fallback value for iterable entry key/value

Browse Source 
As defined in OdinaryGet in the specification.
This commit is contained in:
Idan Horowitz 2021-06-12 23:24:20 +03:00 committed by Linus Groh
parent c0e04768e0
commit 3c83298a26
Notes: sideshowbarker 2024-07-18 12:19:58 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/3c83298a26a
Pull-request: https://github.com/SerenityOS/serenity/pull/8028
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/WeakMapConstructor.cpp
View File

@ -36,6 +36,7 @@ Value WeakMapConstructor::call()
return {};
}
// 24.3.1.1 WeakMap ( [ iterable ] ), https://tc39.es/ecma262/#sec-weakmap-iterable
Value WeakMapConstructor::construct(Function&)
{
auto& vm = this->vm();
@ -57,10 +58,10 @@ Value WeakMapConstructor::construct(Function&)
vm.throw_exception<TypeError>(global_object(), ErrorType::NotAnObject, String::formatted("Iterator value {}", iterator_value.to_string_without_side_effects()));
return IterationDecision::Break;
}
auto key = iterator_value.as_object().get(0);
auto key = iterator_value.as_object().get(0).value_or(js_undefined());
if (vm.exception())
return IterationDecision::Break;
auto value = iterator_value.as_object().get(1);
auto value = iterator_value.as_object().get(1).value_or(js_undefined());
if (vm.exception())
return IterationDecision::Break;
(void)vm.call(adder.as_function(), Value(weak_map), key, value);

8
Userland/Libraries/LibJS/Tests/builtins/WeakMap/WeakMap.js
View File

@ -32,3 +32,11 @@ describe("normal behavior", () => {
expect(a instanceof WeakMap).toBeTrue();
});
});
describe("regressions", () => {
test("missing key/value properties on iterable entry", () => {
expect(() => {
new WeakMap([{}]);
}).toThrowWithMessage(TypeError, "undefined is not an object");
});
});