LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 02:08:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

CrashReporter: Capture backtrace progress callback's arguments by value

Browse Source 
Previously we captured them by reference, but when the deferred code
finally runs from an event loop, the references may be stale.
In that case, value and max of the progressbar are set with random
numbers.
If we were especially unlucky, the `frame_count` turned into a negative
int, and would crash at `VERIFY(min <= max)`.
This commit is contained in:
Sviatoslav Peleshko 2022-02-06 15:59:31 +02:00 committed by Ali Mohammad Pur
parent 46ed6303a2
commit 3caac65cc8
Notes: sideshowbarker 2024-07-17 19:43:05 +09:00 
Author: https://github.com/speles
Commit: https://github.com/SerenityOS/serenity/commit/3caac65cc80
Pull-request: https://github.com/SerenityOS/serenity/pull/12312
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Applications/CrashReporter/main.cpp
View File

@ -277,7 +277,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
coredump->for_each_thread_info([&](auto& thread_info) {
results.thread_backtraces.append(build_backtrace(*coredump, thread_info, thread_index, [&](size_t frame_index, size_t frame_count) {
Core::EventLoop::with_main_locked([&](auto& main) {
main->deferred_invoke([&] {
main->deferred_invoke([&, frame_index, frame_count] {
window->set_progress(100.0f * (float)(frame_index + 1) / (float)frame_count);
progressbar.set_value(frame_index + 1);
progressbar.set_max(frame_count);