From 3cbc0fdbb0c78df399868b6827728c9bae27aa54 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Fri, 27 Jan 2023 17:06:02 +0000 Subject: [PATCH] Kernel: Remove declarations for non-existent methods --- Kernel/Arch/x86_64/ISABus/IDEController.h | 1 - Kernel/Arch/x86_64/Interrupts/IOAPIC.h | 1 - Kernel/Arch/x86_64/PCI/IDELegacyModeController.h | 1 - Kernel/Arch/x86_64/Time/HPET.h | 2 -- Kernel/Bus/PCI/Access.h | 3 --- Kernel/Bus/USB/USBEndpoint.h | 1 - Kernel/Bus/USB/USBHub.h | 2 -- Kernel/CommandLine.h | 1 - Kernel/Devices/MemoryDevice.h | 2 -- Kernel/FileSystem/BlockBasedFileSystem.h | 1 - Kernel/FileSystem/InodeIdentifier.h | 3 --- Kernel/Graphics/Intel/NativeDisplayConnector.h | 1 - Kernel/Graphics/VirtIOGPU/DisplayConnector.h | 4 ---- Kernel/IOWindow.h | 5 ----- Kernel/Net/Intel/E1000NetworkAdapter.h | 3 --- Kernel/Net/Realtek/RTL8168NetworkAdapter.h | 1 - Kernel/Storage/StorageManagement.h | 3 --- Kernel/TTY/VirtualConsole.h | 4 ---- Kernel/Time/TimeManagement.h | 3 --- 19 files changed, 42 deletions(-) diff --git a/Kernel/Arch/x86_64/ISABus/IDEController.h b/Kernel/Arch/x86_64/ISABus/IDEController.h index 0fa83df194f..ed4e37a6b33 100644 --- a/Kernel/Arch/x86_64/ISABus/IDEController.h +++ b/Kernel/Arch/x86_64/ISABus/IDEController.h @@ -23,7 +23,6 @@ public: private: ISAIDEController(); - LockRefPtr device_by_channel_and_position(u32 index) const; ErrorOr initialize_channels(); }; } diff --git a/Kernel/Arch/x86_64/Interrupts/IOAPIC.h b/Kernel/Arch/x86_64/Interrupts/IOAPIC.h index 106f16c996a..fb6d9c1eaef 100644 --- a/Kernel/Arch/x86_64/Interrupts/IOAPIC.h +++ b/Kernel/Arch/x86_64/Interrupts/IOAPIC.h @@ -67,7 +67,6 @@ private: u8 read_redirection_entry_vector(u8 index) const; Optional find_redirection_entry_by_vector(u8 vector) const; - void configure_redirections() const; void write_register(u32 index, u32 value) const; u32 read_register(u32 index) const; diff --git a/Kernel/Arch/x86_64/PCI/IDELegacyModeController.h b/Kernel/Arch/x86_64/PCI/IDELegacyModeController.h index 218a9c4e791..367e31906c4 100644 --- a/Kernel/Arch/x86_64/PCI/IDELegacyModeController.h +++ b/Kernel/Arch/x86_64/PCI/IDELegacyModeController.h @@ -31,7 +31,6 @@ private: bool is_pci_native_mode_enabled_on_secondary_channel() const; explicit PCIIDELegacyModeController(PCI::DeviceIdentifier const&); - LockRefPtr device_by_channel_and_position(u32 index) const; ErrorOr initialize_and_enumerate_channels(bool force_pio); // FIXME: Find a better way to get the ProgrammingInterface diff --git a/Kernel/Arch/x86_64/Time/HPET.h b/Kernel/Arch/x86_64/Time/HPET.h index 8454985774f..cfc31426a34 100644 --- a/Kernel/Arch/x86_64/Time/HPET.h +++ b/Kernel/Arch/x86_64/Time/HPET.h @@ -59,8 +59,6 @@ private: bool is_64bit_capable(u8 comparator_number) const; void set_comparators_to_optimal_interrupt_state(size_t timers_count); - u64 nanoseconds_to_raw_ticks() const; - PhysicalAddress find_acpi_hpet_registers_block(); explicit HPET(PhysicalAddress acpi_hpet); PhysicalAddress m_physical_acpi_hpet_table; diff --git a/Kernel/Bus/PCI/Access.h b/Kernel/Bus/PCI/Access.h index 8c5b5fcab9c..4ee85407716 100644 --- a/Kernel/Bus/PCI/Access.h +++ b/Kernel/Bus/PCI/Access.h @@ -58,9 +58,6 @@ private: bool find_and_register_pci_host_bridges_from_acpi_mcfg_table(PhysicalAddress mcfg); Access(); - Vector get_capabilities(Address); - Optional get_capabilities_pointer(Address address); - mutable RecursiveSpinlock m_access_lock {}; mutable Spinlock m_scan_lock {}; diff --git a/Kernel/Bus/USB/USBEndpoint.h b/Kernel/Bus/USB/USBEndpoint.h index 15329fc391e..fc34d3a8e40 100644 --- a/Kernel/Bus/USB/USBEndpoint.h +++ b/Kernel/Bus/USB/USBEndpoint.h @@ -53,7 +53,6 @@ public: u8 polling_interval() const { return m_descriptor.poll_interval_in_frames; } private: - USBEndpoint(/* TODO */); USBEndpointDescriptor m_descriptor; Pipe m_pipe; diff --git a/Kernel/Bus/USB/USBHub.h b/Kernel/Bus/USB/USBHub.h index 6108bf8828f..dc30e33674d 100644 --- a/Kernel/Bus/USB/USBHub.h +++ b/Kernel/Bus/USB/USBHub.h @@ -90,8 +90,6 @@ public: ErrorOr clear_port_feature(u8, HubFeatureSelector); ErrorOr set_port_feature(u8, HubFeatureSelector); - ErrorOr reset_port(u8); - void check_for_port_updates(); private: diff --git a/Kernel/CommandLine.h b/Kernel/CommandLine.h index a7c5d0f974c..4b015cdf19a 100644 --- a/Kernel/CommandLine.h +++ b/Kernel/CommandLine.h @@ -100,7 +100,6 @@ public: [[nodiscard]] NonnullOwnPtrVector userspace_init_args() const; [[nodiscard]] StringView root_device() const; [[nodiscard]] bool is_nvme_polling_enabled() const; - [[nodiscard]] bool is_i8042_force_scan_code_2() const; [[nodiscard]] size_t switch_to_tty() const; private: diff --git a/Kernel/Devices/MemoryDevice.h b/Kernel/Devices/MemoryDevice.h index a73eca7ca54..25f97a5186b 100644 --- a/Kernel/Devices/MemoryDevice.h +++ b/Kernel/Devices/MemoryDevice.h @@ -30,8 +30,6 @@ private: virtual bool is_seekable() const override { return true; } virtual ErrorOr read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override; virtual ErrorOr write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t) override { return EINVAL; } - - bool is_allowed_range(PhysicalAddress, Memory::VirtualRange const&) const; }; } diff --git a/Kernel/FileSystem/BlockBasedFileSystem.h b/Kernel/FileSystem/BlockBasedFileSystem.h index 58893d5e10f..24a6f16cc7a 100644 --- a/Kernel/FileSystem/BlockBasedFileSystem.h +++ b/Kernel/FileSystem/BlockBasedFileSystem.h @@ -44,7 +44,6 @@ protected: void remove_disk_cache_before_last_unmount(); private: - DiskCache& cache() const; void flush_specific_block_if_needed(BlockIndex index); mutable MutexProtected> m_cache; diff --git a/Kernel/FileSystem/InodeIdentifier.h b/Kernel/FileSystem/InodeIdentifier.h index f99a93e3b27..5edcf1e1dc4 100644 --- a/Kernel/FileSystem/InodeIdentifier.h +++ b/Kernel/FileSystem/InodeIdentifier.h @@ -32,9 +32,6 @@ public: FileSystemID fsid() const { return m_fsid; } InodeIndex index() const { return m_index; } - FileSystem* fs(); - FileSystem const* fs() const; - bool operator==(InodeIdentifier const& other) const { return m_fsid == other.m_fsid && m_index == other.m_index; diff --git a/Kernel/Graphics/Intel/NativeDisplayConnector.h b/Kernel/Graphics/Intel/NativeDisplayConnector.h index d8649d08f63..df7441f7413 100644 --- a/Kernel/Graphics/Intel/NativeDisplayConnector.h +++ b/Kernel/Graphics/Intel/NativeDisplayConnector.h @@ -136,7 +136,6 @@ private: void enable_dpll_without_vga(IntelGraphics::PLLSettings const&, size_t dac_multiplier); void set_display_timings(Graphics::Modesetting const&); void enable_pipe_a(); - void set_framebuffer_parameters(size_t, size_t); void enable_primary_plane(PhysicalAddress fb_address, size_t stride); bool wait_for_enabled_pipe_a(size_t milliseconds_timeout) const; diff --git a/Kernel/Graphics/VirtIOGPU/DisplayConnector.h b/Kernel/Graphics/VirtIOGPU/DisplayConnector.h index f59629a2e89..3ae4591abcd 100644 --- a/Kernel/Graphics/VirtIOGPU/DisplayConnector.h +++ b/Kernel/Graphics/VirtIOGPU/DisplayConnector.h @@ -72,10 +72,6 @@ private: ErrorOr flush_displayed_image(Graphics::VirtIOGPU::Protocol::Rect const& dirty_rect, bool main_buffer); void set_dirty_displayed_rect(Graphics::VirtIOGPU::Protocol::Rect const& dirty_rect, bool main_buffer); - void query_display_information(); - ErrorOr query_edid_from_virtio_adapter(); - void query_display_edid(); - void clear_to_black(); // Member data diff --git a/Kernel/IOWindow.h b/Kernel/IOWindow.h index cce8d4a2054..ea4d7c5bb50 100644 --- a/Kernel/IOWindow.h +++ b/Kernel/IOWindow.h @@ -29,9 +29,6 @@ public: SpaceType space_type() const { return m_space_type; } - template - void write(); - #if ARCH(X86_64) static ErrorOr> create_for_io_space(IOAddress, u64 space_length); #endif @@ -41,8 +38,6 @@ public: ErrorOr> create_from_io_window_with_offset(u64 offset, u64 space_length); ErrorOr> create_from_io_window_with_offset(u64 offset); - bool is_access_valid(u64 offset, size_t byte_size_access) const; - u8 read8(u64 offset); u16 read16(u64 offset); u32 read32(u64 offset); diff --git a/Kernel/Net/Intel/E1000NetworkAdapter.h b/Kernel/Net/Intel/E1000NetworkAdapter.h index a83a0bb0e89..50055d6d8cb 100644 --- a/Kernel/Net/Intel/E1000NetworkAdapter.h +++ b/Kernel/Net/Intel/E1000NetworkAdapter.h @@ -73,9 +73,6 @@ protected: virtual u32 read_eeprom(u8 address); void read_mac_address(); - void write_command(u16 address, u32); - u32 read_command(u16 address); - void initialize_rx_descriptors(); void initialize_tx_descriptors(); diff --git a/Kernel/Net/Realtek/RTL8168NetworkAdapter.h b/Kernel/Net/Realtek/RTL8168NetworkAdapter.h index 3217d30ee06..2b1c741b08a 100644 --- a/Kernel/Net/Realtek/RTL8168NetworkAdapter.h +++ b/Kernel/Net/Realtek/RTL8168NetworkAdapter.h @@ -132,7 +132,6 @@ private: void read_mac_address(); void set_phy_speed(); void start_hardware(); - void initialize(); void startup(); void configure_phy(); diff --git a/Kernel/Storage/StorageManagement.h b/Kernel/Storage/StorageManagement.h index 9772115901f..03fd573f778 100644 --- a/Kernel/Storage/StorageManagement.h +++ b/Kernel/Storage/StorageManagement.h @@ -24,7 +24,6 @@ class StorageManagement { public: StorageManagement(); - static bool initialized(); void initialize(StringView boot_argument, bool force_pio, bool nvme_poll); static StorageManagement& the(); @@ -43,8 +42,6 @@ public: void remove_device(StorageDevice&); private: - bool boot_argument_contains_partition_uuid(); - void enumerate_pci_controllers(bool force_pio, bool nvme_poll); void enumerate_storage_devices(); void enumerate_disk_partitions(); diff --git a/Kernel/TTY/VirtualConsole.h b/Kernel/TTY/VirtualConsole.h index 402ce75ea0d..5a494a5baa5 100644 --- a/Kernel/TTY/VirtualConsole.h +++ b/Kernel/TTY/VirtualConsole.h @@ -121,14 +121,10 @@ private: void clear(); - void inject_string(StringView); - Cell& cell_at(size_t column, size_t row); using ParamVector = Vector; - void on_code_point(u32); - void scroll_down(u16 region_top, u16 region_bottom, size_t count); void scroll_up(u16 region_top, u16 region_bottom, size_t count); void scroll_left(u16 row, u16 column, size_t count); diff --git a/Kernel/Time/TimeManagement.h b/Kernel/Time/TimeManagement.h index afcf58333f7..c0371c6d356 100644 --- a/Kernel/Time/TimeManagement.h +++ b/Kernel/Time/TimeManagement.h @@ -55,7 +55,6 @@ public: bool is_system_timer(HardwareTimerBase const&) const; - static void update_time_hpet(RegisterState const&); void increment_time_since_boot(); static bool is_hpet_periodic_mode_allowed(); @@ -97,8 +96,6 @@ private: void set_system_timer(HardwareTimerBase&); static void system_timer_tick(RegisterState const&); - static u64 scheduling_current_time(bool); - // Variables between m_update1 and m_update2 are synchronized // FIXME: Replace m_update1 and m_update2 with a SpinlockLocker Atomic m_update1 { 0 };