LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-27 05:05:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Browser+WebDriver: Set the initial URL to about:blank from WebDriver

Browse Source 
We already do this for headless-browser. There's no need to open any URL
other than about:blank when starting a WebDriver session. We should also
do this from WebDriver code, rather than in special logic in Browser's
main.cpp.
This commit is contained in:
Timothy Flynn 2023-08-08 16:05:14 -04:00 committed by Andreas Kling
parent 93ffa77370
commit 3e2449d1fe
Notes: sideshowbarker 2024-07-17 07:09:53 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/3e2449d1fe
Pull-request: https://github.com/SerenityOS/serenity/pull/20438
Reviewed-by: https://github.com/AtkinsSJ
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Ladybird/WebDriver/main.cpp
View File

@ -36,6 +36,7 @@ static ErrorOr<pid_t> launch_browser(DeprecatedString const& socket_path)
Array { Array {
"--webdriver-content-path", "--webdriver-content-path",
socket_path.characters(), socket_path.characters(),
"about:blank",
}); });
} }

3
Userland/Applications/Browser/main.cpp
View File

@ -114,9 +114,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
TRY(Desktop::Launcher::add_allowed_url(URL::create_with_file_scheme(Core::StandardPaths::downloads_directory()))); TRY(Desktop::Launcher::add_allowed_url(URL::create_with_file_scheme(Core::StandardPaths::downloads_directory())));
TRY(Desktop::Launcher::seal_allowlist()); TRY(Desktop::Launcher::seal_allowlist());
if (!Browser::g_webdriver_content_ipc_path.is_empty())
specified_urls.empend("about:blank");
TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw")); TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw"));
TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw")); TRY(Core::System::unveil("/tmp/session/%sid/portal/filesystemaccess", "rw"));
TRY(Core::System::unveil("/tmp/session/%sid/portal/image", "rw")); TRY(Core::System::unveil("/tmp/session/%sid/portal/image", "rw"));

1
Userland/Services/WebDriver/main.cpp
View File

@ -20,6 +20,7 @@ static ErrorOr<pid_t> launch_browser(DeprecatedString const& socket_path)
Array { Array {
"--webdriver-content-path", "--webdriver-content-path",
socket_path.characters(), socket_path.characters(),
"about:blank",
}); });
} }