LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 05:25:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Meta: Revise lint-commit.sh regex for the title

Browse Source 
This mainly changes two aspects:
- The category can now be a single letter, such as 'w' to indicate the
  file Utilities/w.cpp
- Spaces in the category (or list) are no longer allowed. This follows
  the lived practice of writing category lists as "Foo+Bar: Quux"

Closes #15243.
This commit is contained in:
Ben Wiederhake 2022-09-14 22:48:54 +02:00 committed by Sam Atkins
parent a60c5166c6
commit 42db468ef5
Notes: sideshowbarker 2024-07-17 07:09:27 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/42db468ef5
Pull-request: https://github.com/SerenityOS/serenity/pull/15249
Issue: https://github.com/SerenityOS/serenity/issues/15243
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Meta/lint-commit.sh
View File

@ -34,7 +34,7 @@ while read -r line; do
error "Empty line between commit title and body is missing"
fi
category_pattern="^\S.*?\S: .+"
category_pattern='^(Revert "|\S+: )'
if [[ $line_number -eq 1 ]] && (echo "$line" | grep -E -v -q "$category_pattern"); then
error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)"
fi