LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Fix Document construction mishap in <template> element

Browse Source 
Ref-counted objects must not be stack allocated. Make DOM::Document's
constructor private to avoid this issue. (I wish we could mark classes
as heap-only..)
This commit is contained in:
Andreas Kling 2020-10-23 08:31:26 +02:00
parent 691b105885
commit 46c15276e9
Notes: sideshowbarker 2024-07-19 01:47:41 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/46c15276e95
7 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Applications/Browser/ConsoleWidget.cpp
View File

@ -47,7 +47,7 @@ ConsoleWidget::ConsoleWidget()
set_layout<GUI::VerticalBoxLayout>();
set_fill_with_background_color(true);
auto base_document = adopt(*new Web::DOM::Document);
auto base_document = Web::DOM::Document::create();
base_document->append_child(adopt(*new Web::DOM::DocumentType(base_document)));
auto html_element = base_document->create_element("html");
base_document->append_child(html_element);

2
Applications/IRCClient/IRCLogBuffer.cpp
View File

@ -40,7 +40,7 @@ NonnullRefPtr<IRCLogBuffer> IRCLogBuffer::create()
IRCLogBuffer::IRCLogBuffer()
{
m_document = adopt(*new Web::DOM::Document);
m_document = Web::DOM::Document::create();
m_document->append_child(adopt(*new Web::DOM::DocumentType(document())));
auto html_element = m_document->create_element("html");
m_document->append_child(html_element);

4
Libraries/LibWeb/DOM/Document.h
View File

@ -57,7 +57,7 @@ class Document
public:
using WrapperType = Bindings::DocumentWrapper;
explicit Document(const URL& = {});
static NonnullRefPtr<Document> create(const URL& url = {}) { return adopt(*new Document(url)); }
virtual ~Document() override;
void set_url(const URL& url) { m_url = url; }
@ -192,6 +192,8 @@ public:
Window& window() { return *m_window; }
private:
explicit Document(const URL&);
virtual RefPtr<LayoutNode> create_layout_node(const CSS::StyleProperties* parent_style) override;
void tear_down_layout_tree();

4
Libraries/LibWeb/HTML/HTMLTemplateElement.cpp
View File

@ -44,8 +44,8 @@ DOM::Document& HTMLTemplateElement::appropriate_template_contents_owner_document
{
if (!document.created_for_appropriate_template_contents()) {
if (!document.associated_inert_template_document()) {
DOM::Document new_document;
new_document.set_created_for_appropriate_template_contents(true);
auto new_document = DOM::Document::create();
new_document->set_created_for_appropriate_template_contents(true);
// FIXME: If doc is an HTML document, mark new doc as an HTML document also.

2
Libraries/LibWeb/HTML/Parser/HTMLDocumentParser.cpp
View File

@ -118,7 +118,7 @@ RefPtr<DOM::Document> parse_html_document(const StringView& data, const URL& url
HTMLDocumentParser::HTMLDocumentParser(const StringView& input, const String& encoding)
: m_tokenizer(input, encoding)
{
m_document = adopt(*new DOM::Document);
m_document = DOM::Document::create();
}
HTMLDocumentParser::HTMLDocumentParser(const StringView& input, const String& encoding, DOM::Document& existing_document)

4
Libraries/LibWeb/Loader/FrameLoader.cpp
View File

@ -63,7 +63,7 @@ static RefPtr<DOM::Document> create_markdown_document(const ByteBuffer& data, co
static RefPtr<DOM::Document> create_text_document(const ByteBuffer& data, const URL& url)
{
auto document = adopt(*new DOM::Document(url));
auto document = DOM::Document::create(url);
auto html_element = document->create_element("html");
document->append_child(html_element);
@ -88,7 +88,7 @@ static RefPtr<DOM::Document> create_text_document(const ByteBuffer& data, const
static RefPtr<DOM::Document> create_image_document(const ByteBuffer& data, const URL& url)
{
auto document = adopt(*new DOM::Document(url));
auto document = DOM::Document::create(url);
auto image_decoder = Gfx::ImageDecoder::create(data.data(), data.size());
auto bitmap = image_decoder->bitmap();

2
Userland/test-web.cpp
View File

@ -686,7 +686,7 @@ int main(int argc, char** argv)
main_widget.set_layout<GUI::VerticalBoxLayout>();
auto& view = main_widget.add<Web::InProcessWebView>();
view.set_document(adopt(*new Web::DOM::Document));
view.set_document(Web::DOM::Document::create());
if (show_window) {
window->set_title("LibWeb Test Window");