LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-27 13:11:46 +03:00
Code Issues Packages Projects Releases Wiki Activity

Shell: Remove '#' from the list of acceptable bareword characters

Browse Source 
This stops the shell from always interpreting '#' as the start of a
comment in non-Posix mode.
This commit is contained in:
implicitfield 2023-10-28 23:56:46 +04:00 committed by Ali Mohammad Pur
parent 4afd782477
commit 4b60a99573
Notes: sideshowbarker 2024-07-17 00:59:43 +09:00 
Author: https://github.com/implicitfield
Commit: https://github.com/SerenityOS/serenity/commit/4b60a99573
Pull-request: https://github.com/SerenityOS/serenity/pull/21656
Issue: https://github.com/SerenityOS/serenity/issues/21650
Reviewed-by: https://github.com/alimpfard ✅
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Base/usr/share/man/man5/Shell.md
View File

@ -104,7 +104,7 @@ Any two expressions joined by the Join operator (` ` [whitespace]), or a _variab
* Syntactic Lists: Any _list_ enclosed in parentheses (`(` and `)`)
##### Comments
Any text following a `#` in _bareword_ position, up to but not including a newline
Any text following and including that in a word starting with `#`, up to but not including a newline
##### Keywords
The following tokens:
@ -497,7 +497,7 @@ variable_ref :: '$' identifier
slice :: '[' brace_expansion_spec ']'
comment :: '#' [^\n]*
comment :: (?<!\w) '#' .*
immediate_expression :: '$' '{' immediate_function expression* '}'
@ -515,8 +515,8 @@ word_selector :: number
| '^' {== 0}
| '$' {== end}
bareword :: [^"'*$&#|()[\]{} ?;<>] bareword?
| '\' [^"'*$&#|()[\]{} ?;<>] bareword?
bareword :: [^"'*$&|()[\]{} ?;<>] bareword?
| '\' [^"'*$&|()[\]{} ?;<>] bareword?
bareword_with_tilde_expansion :: '~' bareword?

2
Userland/Shell/Parser.cpp
View File

@ -1913,7 +1913,7 @@ RefPtr<AST::Node> Parser::parse_bareword()
auto rule_start = push_start();
StringBuilder builder;
auto is_acceptable_bareword_character = [&](char c) {
return strchr("\\\"'*$&#|(){} ?;<>\n", c) == nullptr
return strchr("\\\"'*$&|(){} ?;<>\n", c) == nullptr
&& !m_extra_chars_not_allowed_in_barewords.contains_slow(c);
};
while (!at_end()) {

6
Userland/Shell/Parser.h
View File

@ -292,7 +292,7 @@ variable_ref :: '$' identifier
slice :: '[' brace_expansion_spec ']'
comment :: '#' [^\n]*
comment :: (?<!\w) '#' .*
immediate_expression :: '$' '{' immediate_function expression* '}'
@ -310,8 +310,8 @@ word_selector :: number
| '^' {== 0}
| '$' {== end}
bareword :: [^"'*$&#|()[\]{} ?;<>] bareword?
| '\' [^"'*$&#|()[\]{} ?;<>] bareword?
bareword :: [^"'*$&|()[\]{} ?;<>] bareword?
| '\' [^"'*$&|()[\]{} ?;<>] bareword?
bareword_with_tilde_expansion :: '~' bareword?