From 4c94202e9734099b6e2839f5495b8280eec2ab2f Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 14 Jun 2024 17:13:31 +0200 Subject: [PATCH] LibWeb: Remove unnecessary FIXME marker for CSSStyleDeclaration.cssFloat --- .../LibWeb/Text/expected/css/cssFloat-property.txt | 2 ++ Tests/LibWeb/Text/input/css/cssFloat-property.html | 13 +++++++++++++ .../Libraries/LibWeb/CSS/CSSStyleDeclaration.idl | 5 ++++- 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 Tests/LibWeb/Text/expected/css/cssFloat-property.txt create mode 100644 Tests/LibWeb/Text/input/css/cssFloat-property.html diff --git a/Tests/LibWeb/Text/expected/css/cssFloat-property.txt b/Tests/LibWeb/Text/expected/css/cssFloat-property.txt new file mode 100644 index 00000000000..2f45e4436c6 --- /dev/null +++ b/Tests/LibWeb/Text/expected/css/cssFloat-property.txt @@ -0,0 +1,2 @@ +spanRule: [object CSSStyleRule] ~ span { float: right; } +spanRule.style.cssFloat: right diff --git a/Tests/LibWeb/Text/input/css/cssFloat-property.html b/Tests/LibWeb/Text/input/css/cssFloat-property.html new file mode 100644 index 00000000000..a3f197df2fe --- /dev/null +++ b/Tests/LibWeb/Text/input/css/cssFloat-property.html @@ -0,0 +1,13 @@ + + + diff --git a/Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.idl b/Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.idl index 9440fbbfa3c..a13104d6d86 100644 --- a/Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.idl +++ b/Userland/Libraries/LibWeb/CSS/CSSStyleDeclaration.idl @@ -14,6 +14,9 @@ interface CSSStyleDeclaration { [CEReactions] CSSOMString removeProperty(CSSOMString property); readonly attribute CSSRule? parentRule; - [FIXME, CEReactions, LegacyNullToEmptyString] attribute CSSOMString cssFloat; + + // NOTE: cssFloat is implemented manually in the bindings code, along with the other property accessors. + // Hence, this does not need to be implemented. + // [CEReactions, LegacyNullToEmptyString] attribute CSSOMString cssFloat; };