mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 13:36:13 +03:00
Meta: Only check changed files in check-debug-flags during pre-commit
This speeds up the script from about 170ms down to about 80ms for changes in Debug.h.in or similarly "DEBUG"-rich files, down to <10ms for more common changesets. 160ms may not feel like much, but it adds up quickly, especially since we run a dozen scripts during pre-commit.
This commit is contained in:
parent
88c8ad840d
commit
4caaa78baf
Notes:
sideshowbarker
2024-07-17 06:51:11 +09:00
Author: https://github.com/BenWiederhake Commit: https://github.com/SerenityOS/serenity/commit/4caaa78baf Pull-request: https://github.com/SerenityOS/serenity/pull/15281 Reviewed-by: https://github.com/bgianfo ✅
@ -21,15 +21,27 @@ while IFS= read -r FLAG; do
|
||||
MISSING_FLAGS=y
|
||||
fi
|
||||
done < <(
|
||||
git ls-files -- \
|
||||
'*.cpp' \
|
||||
'*.h' \
|
||||
'*.in' \
|
||||
':!:Kernel/FileSystem/ext2_fs.h' \
|
||||
if [ "$#" -eq "0" ]; then
|
||||
git ls-files -- \
|
||||
'*.cpp' \
|
||||
'*.h' \
|
||||
'*.in' \
|
||||
':!:Kernel/FileSystem/ext2_fs.h'
|
||||
else
|
||||
# We're in the middle of a pre-commit run, so we should only check the files that have
|
||||
# actually changed. The reason is that "git ls-files | grep" on the entire repo takes
|
||||
# about 100ms. That is perfectly fine during a CI run, but becomes noticable during a
|
||||
# pre-commit hook. It is unnecessary to check the entire repository on every single
|
||||
# commit, so we save some time here.
|
||||
for file in "$@"; do
|
||||
if [[ ("${file}" =~ \.cpp || "${file}" =~ \.h || "${file}" =~ \.in) && ! "${file}" == "Kernel/FileSystem/ext2_fs.h" ]]; then
|
||||
echo "$file"
|
||||
fi
|
||||
done
|
||||
fi \
|
||||
| xargs grep -E '(_DEBUG|DEBUG_)' \
|
||||
| sed -re 's,^.*[^a-zA-Z0-9_]([a-zA-Z0-9_]*DEBUG[a-zA-Z0-9_]*).*$,\1,' \
|
||||
| sort \
|
||||
| uniq
|
||||
| sort -u
|
||||
)
|
||||
|
||||
if [ "n" != "${MISSING_FLAGS}" ] ; then
|
||||
|
Loading…
Reference in New Issue
Block a user