LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-07 20:31:04 +03:00
Code Issues Packages Projects Releases Wiki Activity

Revert "LibWeb: Run IntersectionObserver steps only when needed"

Browse Source 
This reverts commit 11b4216e65.
This commit is contained in:
Andreas Kling 2024-03-19 13:04:39 +01:00
parent 1e023a589d
commit 4e4b9f440f
Notes: sideshowbarker 2024-07-17 02:05:41 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/4e4b9f440f
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibWeb/DOM/Document.cpp
View File

@ -1114,9 +1114,6 @@ void Document::update_layout()
m_needs_layout = false; m_needs_layout = false;
m_layout_update_timer->stop(); m_layout_update_timer->stop();
// OPTIMIZATION: We do this here instead of in HTML::EventLoop::process() to avoid redundant work.
run_the_update_intersection_observations_steps(HighResolutionTime::unsafe_shared_current_time());
} }
[[nodiscard]] static Element::RequiredInvalidationAfterStyleChange update_style_recursively(Node& node) [[nodiscard]] static Element::RequiredInvalidationAfterStyleChange update_style_recursively(Node& node)

4
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View File

@ -249,7 +249,9 @@ void EventLoop::process()
}); });
// 14. For each fully active Document in docs, run the update intersection observations steps for that Document, passing in now as the timestamp. [INTERSECTIONOBSERVER] // 14. For each fully active Document in docs, run the update intersection observations steps for that Document, passing in now as the timestamp. [INTERSECTIONOBSERVER]
// OPTIMIZATION: We do this automatically after layout or viewport changes, so we don't need to do it here. for_each_fully_active_document_in_docs([&](DOM::Document& document) {
document.run_the_update_intersection_observations_steps(now);
});
// FIXME: 15. Invoke the mark paint timing algorithm for each Document object in docs. // FIXME: 15. Invoke the mark paint timing algorithm for each Document object in docs.

4
Userland/Libraries/LibWeb/HTML/Navigable.cpp
View File

@ -29,7 +29,6 @@
#include <LibWeb/HTML/TraversableNavigable.h> #include <LibWeb/HTML/TraversableNavigable.h>
#include <LibWeb/HTML/Window.h> #include <LibWeb/HTML/Window.h>
#include <LibWeb/HTML/WindowProxy.h> #include <LibWeb/HTML/WindowProxy.h>
#include <LibWeb/HighResolutionTime/TimeOrigin.h>
#include <LibWeb/Infra/Strings.h> #include <LibWeb/Infra/Strings.h>
#include <LibWeb/Layout/Node.h> #include <LibWeb/Layout/Node.h>
#include <LibWeb/Loader/GeneratedPagesLoader.h> #include <LibWeb/Loader/GeneratedPagesLoader.h>
@ -1949,9 +1948,6 @@ void Navigable::scroll_offset_did_change()
// 3. Append doc to doc’s pending scroll event targets. // 3. Append doc to doc’s pending scroll event targets.
doc->pending_scroll_event_targets().append(*doc); doc->pending_scroll_event_targets().append(*doc);
// OPTIMIZATION: We do this here instead of in HTML::EventLoop::process() to avoid redundant work.
doc->run_the_update_intersection_observations_steps(HighResolutionTime::unsafe_shared_current_time());
} }
CSSPixelRect Navigable::to_top_level_rect(CSSPixelRect const& a_rect) CSSPixelRect Navigable::to_top_level_rect(CSSPixelRect const& a_rect)