LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 18:37:58 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Abstract out even more duplicated logic

Browse Source
This commit is contained in:
thislooksfun 2021-10-27 19:52:15 -05:00 committed by Andreas Kling
parent d4eef0f17d
commit 4e5bf5c138
Notes: sideshowbarker 2024-07-18 01:34:47 +09:00 
Author: https://github.com/thislooksfun
Commit: https://github.com/SerenityOS/serenity/commit/4e5bf5c1386
Pull-request: https://github.com/SerenityOS/serenity/pull/10642
1 changed files with 16 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
Userland/Libraries/LibGUI/GMLAutocompleteProvider.cpp
View File

@ -155,6 +155,20 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
identifier_entries.empend("layout: ", partial_input_length, Language::Unspecified, "layout");
};
auto register_properties_and_widgets_matching_pattern = [&](String pattern, size_t partial_input_length) {
if (!class_names.is_empty()) {
register_class_properties_matching_pattern(pattern, partial_input_length);
auto parent_registration = Core::ObjectClassRegistration::find(class_names.last());
if (parent_registration && parent_registration->is_derived_from(layout_class)) {
// Layouts can't have child classes, so why suggest them?
return;
}
}
register_widgets_matching_pattern(pattern, partial_input_length);
};
bool after_token_on_same_line = last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line();
switch (state) {
case Free:
@ -191,18 +205,7 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
break;
}
auto fuzzy_pattern = make_fuzzy(identifier_string);
if (!class_names.is_empty()) {
register_class_properties_matching_pattern(fuzzy_pattern, identifier_string.length());
auto parent_registration = Core::ObjectClassRegistration::find(class_names.last());
if (parent_registration && parent_registration->is_derived_from(layout_class)) {
// Layouts can't have child classes, so why suggest them?
break;
}
}
register_widgets_matching_pattern(fuzzy_pattern, identifier_string.length());
register_properties_and_widgets_matching_pattern(make_fuzzy(identifier_string), identifier_string.length());
break;
}
case AfterClassName: {
@ -213,17 +216,8 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
break;
}
}
if (!class_names.is_empty()) {
register_class_properties_matching_pattern("*", 0u);
auto parent_registration = Core::ObjectClassRegistration::find(class_names.last());
if (parent_registration && parent_registration->is_derived_from(layout_class)) {
// Layouts can't have child classes, so why suggest them?
break;
}
}
register_widgets_matching_pattern("*", 0u);
register_properties_and_widgets_matching_pattern("*", 0u);
break;
}
case AfterIdentifier: