LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 01:08:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Remove alreadyDeclared check in FunctionDeclarationInstantiation

Browse Source 
We don't need to check if a function parameter is already declared
while creating bindings for them because we deduplicate their names by
storing them in a hash table in one of the previous steps.

This change makes React-Redux-TodoMVC test in Speedometer run 2%
faster.
This commit is contained in:
Aliaksandr Kalenik 2023-09-19 11:37:42 +02:00 committed by Andreas Kling
parent b603e860af
commit 4ff4ac11b9
Notes: sideshowbarker 2024-07-17 18:06:52 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/4ff4ac11b9
Pull-request: https://github.com/SerenityOS/serenity/pull/21155
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Userland/Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View File

@ -544,20 +544,18 @@ ThrowCompletionOr<void> ECMAScriptFunctionObject::function_declaration_instantia
// 21. For each String paramName of parameterNames, do
for (auto const& parameter_name : m_parameter_names) {
// a. Let alreadyDeclared be ! env.HasBinding(paramName).
auto already_declared = MUST(environment->has_binding(parameter_name));
// b. NOTE: Early errors ensure that duplicate parameter names can only occur in non-strict functions that do not have parameter default values or rest parameters.
// c. If alreadyDeclared is false, then
if (!already_declared) {
// i. Perform ! env.CreateMutableBinding(paramName, false).
MUST(environment->create_mutable_binding(vm, parameter_name, false));
// NOTE: alreadyDeclared is always false because we use hash table for parameterNames
// i. Perform ! env.CreateMutableBinding(paramName, false).
MUST(environment->create_mutable_binding(vm, parameter_name, false));
// ii. If hasDuplicates is true, then
if (m_has_duplicates) {
// 1. Perform ! env.InitializeBinding(paramName, undefined).
MUST(environment->initialize_binding(vm, parameter_name, js_undefined(), Environment::InitializeBindingHint::Normal));
}
// ii. If hasDuplicates is true, then
if (m_has_duplicates) {
// 1. Perform ! env.InitializeBinding(paramName, undefined).
MUST(environment->initialize_binding(vm, parameter_name, js_undefined(), Environment::InitializeBindingHint::Normal));
}
}