LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-17 01:10:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

CI: Do not expect test-results.log to exist on AArch64

Browse Source 
The AArch64 port is still unstable, and in some cases, we may encounter
a kernel panic or Shell crash that prevents `test-results.log` from
being written to disk. The CI job would fail when we tried to print out
the contents of this non-existent file. We have been ignoring its
contents anyway, so let's not read it at all.
This commit is contained in:
Daniel Bertalan 2023-05-30 09:50:24 +02:00 committed by Jelle Raaijmakers
parent 7f9ede07bc
commit 540ea9f1c4
Notes: sideshowbarker 2024-07-16 21:34:08 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/540ea9f1c4
Pull-request: https://github.com/SerenityOS/serenity/pull/19147
Reviewed-by: https://github.com/gmta ✅
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.github/workflows/cmake.yml vendored
View File

@ -246,6 +246,10 @@ jobs:
echo "::group::ninja run # Qemu output"
ninja run
echo "::endgroup::"
if ${{ matrix.arch == 'aarch64' }}; then
# FIXME: Actually verify test results when all tests are expected to pass.
exit 0
fi
echo "::group::Verify Output File"
mkdir fsmount
sudo mount -t ext2 -o loop,rw _disk_image fsmount
@ -253,11 +257,6 @@ jobs:
sudo cat fsmount/home/anon/test-results.log
if ! sudo grep -q "Failed: 0" fsmount/home/anon/test-results.log
then
if ${{ matrix.arch == 'aarch64' }}; then
# FIXME: Remove this once all tests pass on AArch64
echo "::warning:: :^( Some tests failed"
exit 0
fi
echo "::error:: :^( Tests failed, failing job"
exit 1
fi