LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibDSP: Fix potential slicing issue in volume_from_envelope

Browse Source 
Use pointer or reference to avoid slicing from "PitchedEnvelope"
to "Envelope". This was found by SonarCloud.
This commit is contained in:
Brian Gianforcaro 2021-11-27 15:18:43 -08:00 committed by Brian Gianforcaro
parent a225b26d88
commit 55aecf5381
Notes: sideshowbarker 2024-07-17 23:23:09 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/55aecf5381d
Pull-request: https://github.com/SerenityOS/serenity/pull/11124
Reviewed-by: https://github.com/itamar8910 ✅
Reviewed-by: https://github.com/kleinesfilmroellchen ✅
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibDSP/Envelope.h
View File

@ -50,7 +50,7 @@ struct Envelope {
constexpr void reset() { envelope = -1; }
constexpr operator EnvelopeState()
constexpr operator EnvelopeState() const
{
if (!is_active())
return EnvelopeState::Off;

2
Userland/Libraries/LibDSP/Synthesizers.cpp
View File

@ -64,7 +64,7 @@ Signal Classic::process_impl(Signal const& input_signal)
}
// Linear ADSR envelope with no peak adjustment.
double Classic::volume_from_envelope(Envelope envelope)
double Classic::volume_from_envelope(Envelope const& envelope)
{
switch (static_cast<EnvelopeState>(envelope)) {
case EnvelopeState::Off:

2
Userland/Libraries/LibDSP/Synthesizers.h
View File

@ -49,7 +49,7 @@ public:
private:
virtual Signal process_impl(Signal const&) override;
double volume_from_envelope(Envelope);
double volume_from_envelope(Envelope const&);
double wave_position(u8 note);
double samples_per_cycle(u8 note);
double sin_position(u8 note);