mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 05:25:32 +03:00
Tests: Remove all file(GLOB) from CMakeLists in Tests
Using a file(GLOB) to find all the test files in a directory is an easy hack to get things started, but has some drawbacks. Namely, if you add a test, it won't be found again without re-running CMake. `ninja` seems to do this automatically, but it would be nice to one day stop seeing it rechecking our globbed directories.
This commit is contained in:
parent
b5a145b466
commit
58797a1289
Notes:
sideshowbarker
2024-07-18 04:54:54 +09:00
Author: https://github.com/ADKaster Commit: https://github.com/SerenityOS/serenity/commit/58797a1289b Pull-request: https://github.com/SerenityOS/serenity/pull/9743
@ -70,6 +70,6 @@ set(AK_TEST_SOURCES
|
||||
TestWeakPtr.cpp
|
||||
)
|
||||
|
||||
foreach(source ${AK_TEST_SOURCES})
|
||||
serenity_test(${source} AK)
|
||||
foreach(source IN LISTS AK_TEST_SOURCES)
|
||||
serenity_test("${source}" AK)
|
||||
endforeach()
|
||||
|
@ -1,18 +1,46 @@
|
||||
file(GLOB CMD_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
file(GLOB LIBTEST_BASED_SOURCES "Test*.cpp")
|
||||
list(REMOVE_ITEM CMD_SOURCES ${LIBTEST_BASED_SOURCES})
|
||||
set(TEST_SOURCES
|
||||
bind-local-socket-to-symlink.cpp
|
||||
bxvga-mmap-kernel-into-userspace.cpp
|
||||
crash-fcntl-invalid-cmd.cpp
|
||||
elf-execve-mmap-race.cpp
|
||||
elf-symbolication-kernel-read-exploit.cpp
|
||||
fuzz-syscalls.cpp
|
||||
kill-pidtid-confusion.cpp
|
||||
mmap-write-into-running-programs-executable-file.cpp
|
||||
mprotect-multi-region-mprotect.cpp
|
||||
munmap-multi-region-unmapping.cpp
|
||||
nanosleep-race-outbuf-munmap.cpp
|
||||
null-deref-close-during-select.cpp
|
||||
null-deref-crash-during-pthread_join.cpp
|
||||
path-resolution-race.cpp
|
||||
pthread-cond-timedwait-example.cpp
|
||||
setpgid-across-sessions-without-leader.cpp
|
||||
stress-truncate.cpp
|
||||
stress-writeread.cpp
|
||||
uaf-close-while-blocked-in-read.cpp
|
||||
unveil-symlinks.cpp
|
||||
)
|
||||
|
||||
# FIXME: These tests do not use LibTest
|
||||
foreach(CMD_SRC ${CMD_SOURCES})
|
||||
get_filename_component(CMD_NAME ${CMD_SRC} NAME_WE)
|
||||
add_executable(${CMD_NAME} ${CMD_SRC})
|
||||
target_link_libraries(${CMD_NAME} LibCore)
|
||||
install(TARGETS ${CMD_NAME} RUNTIME DESTINATION usr/Tests/Kernel/Legacy)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
get_filename_component(test_name "${source}" NAME_WE)
|
||||
add_executable("${test_name}" "${source}")
|
||||
target_link_libraries("${test_name}" LibCore)
|
||||
install(TARGETS "${test_name}" RUNTIME DESTINATION usr/Tests/Kernel/Legacy)
|
||||
endforeach()
|
||||
|
||||
set(LIBTEST_BASED_SOURCES
|
||||
TestEFault.cpp
|
||||
TestKernelAlarm.cpp
|
||||
TestKernelFilePermissions.cpp
|
||||
TestKernelPledge.cpp
|
||||
TestKernelUnveil.cpp
|
||||
TestMunMap.cpp
|
||||
TestProcFS.cpp
|
||||
)
|
||||
|
||||
foreach(TEST_SRC ${LIBTEST_BASED_SOURCES})
|
||||
serenity_test(${TEST_SRC} Kernel)
|
||||
foreach(libtest_source IN LISTS LIBTEST_BASED_SOURCES)
|
||||
serenity_test("${libtest_source}" Kernel)
|
||||
endforeach()
|
||||
|
||||
target_link_libraries(elf-execve-mmap-race LibPthread)
|
||||
|
@ -1,5 +1,9 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
TestDeflate.cpp
|
||||
TestGzip.cpp
|
||||
TestZlib.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibCompress LIBS LibCompress)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibCompress LIBS LibCompress)
|
||||
endforeach()
|
||||
|
@ -1,13 +1,12 @@
|
||||
set(
|
||||
TEST_SOURCES
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/TestLibCoreArgsParser.cpp
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/TestLibCoreFileWatcher.cpp
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/TestLibCoreIODevice.cpp
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/TestLibCoreDeferredInvoke.cpp
|
||||
set(TEST_SOURCES
|
||||
TestLibCoreArgsParser.cpp
|
||||
TestLibCoreFileWatcher.cpp
|
||||
TestLibCoreIODevice.cpp
|
||||
TestLibCoreDeferredInvoke.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibCore)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibCore)
|
||||
endforeach()
|
||||
|
||||
install(FILES long_lines.txt DESTINATION usr/Tests/LibCore)
|
||||
|
@ -1,5 +1,8 @@
|
||||
file(GLOB CMD_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
test-cpp-parser.cpp
|
||||
test-cpp-preprocessor.cpp
|
||||
)
|
||||
|
||||
foreach(CMD_SRC ${CMD_SOURCES})
|
||||
serenity_test(${CMD_SRC} LibCpp LIBS LibCpp)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibCpp LIBS LibCpp)
|
||||
endforeach()
|
||||
|
@ -1,4 +1,12 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibCrypto LIBS LibCrypto)
|
||||
set(TEST_SOURCES
|
||||
TestAES.cpp
|
||||
TestBigInteger.cpp
|
||||
TestChecksum.cpp
|
||||
TestHash.cpp
|
||||
TestHMAC.cpp
|
||||
TestRSA.cpp
|
||||
)
|
||||
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibCrypto LIBS LibCrypto)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,7 @@
|
||||
file(GLOB CMD_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
test-elf.cpp
|
||||
)
|
||||
|
||||
foreach(CMD_SRC ${CMD_SOURCES})
|
||||
serenity_test(${CMD_SRC} LibELF)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibELF)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,9 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
BenchmarkGfxPainter.cpp
|
||||
TestFontHandling.cpp
|
||||
TestImageDecoder.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibGfx LIBS LibGUI)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibGfx LIBS LibGUI)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,7 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
TestQuotedPrintable.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibIMAP LIBS LibIMAP)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibIMAP LIBS LibIMAP)
|
||||
endforeach()
|
||||
|
@ -1,6 +1,8 @@
|
||||
file(GLOB CMD_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
test-math.cpp
|
||||
)
|
||||
add_compile_options(-fno-builtin)
|
||||
|
||||
foreach(CMD_SRC ${CMD_SOURCES})
|
||||
serenity_test(${CMD_SRC} LibM)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibM)
|
||||
endforeach()
|
||||
|
@ -1,6 +1,9 @@
|
||||
include(${SERENITY_PROJECT_ROOT}/Meta/CMake/commonmark_spec.cmake)
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibMarkdown LIBS LibMarkdown)
|
||||
set(TEST_SOURCES
|
||||
TestCommonmark.cpp
|
||||
)
|
||||
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibMarkdown LIBS LibMarkdown)
|
||||
endforeach()
|
||||
|
@ -1,4 +1,7 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibPthread LIBS LibPthread)
|
||||
set(TEST_SOURCES
|
||||
TestLibPthreadSpinLocks.cpp
|
||||
)
|
||||
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibPthread LIBS LibPthread)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,9 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
Benchmark.cpp
|
||||
Regex.cpp
|
||||
RegexLibC.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibRegex LIBS LibRegex)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibRegex LIBS LibRegex)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,13 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
TestSqlBtreeIndex.cpp
|
||||
TestSqlDatabase.cpp
|
||||
TestSqlExpressionParser.cpp
|
||||
TestSqlHashIndex.cpp
|
||||
TestSqlStatementExecution.cpp
|
||||
TestSqlStatementParser.cpp
|
||||
TestSqlValueAndTuple.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibSQL LIBS LibSQL LibIPC)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibSQL LIBS LibSQL LibIPC)
|
||||
endforeach()
|
||||
|
@ -1,4 +1,7 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibTLS LIBS LibTLS LibCrypto)
|
||||
set(TEST_SOURCES
|
||||
TestTLSHandshake.cpp
|
||||
)
|
||||
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibTLS LIBS LibTLS LibCrypto)
|
||||
endforeach()
|
||||
|
@ -1,4 +1,7 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibThreading LIBS LibThreading LibPthread)
|
||||
set(TEST_SOURCES
|
||||
TestThread.cpp
|
||||
)
|
||||
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibThreading LIBS LibThreading LibPthread)
|
||||
endforeach()
|
||||
|
@ -1,5 +1,8 @@
|
||||
file(GLOB TEST_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
TestUnicodeCharacterTypes.cpp
|
||||
TestUnicodeLocale.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibUnicode LIBS LibUnicode)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibUnicode LIBS LibUnicode)
|
||||
endforeach()
|
||||
|
@ -1,10 +1,9 @@
|
||||
set(
|
||||
TEST_SOURCES
|
||||
${CMAKE_CURRENT_SOURCE_DIR}/TestHTMLTokenizer.cpp
|
||||
set(TEST_SOURCES
|
||||
TestHTMLTokenizer.cpp
|
||||
)
|
||||
|
||||
foreach(source ${TEST_SOURCES})
|
||||
serenity_test(${source} LibWeb LIBS LibWeb)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
serenity_test("${source}" LibWeb LIBS LibWeb)
|
||||
endforeach()
|
||||
|
||||
serenity_testjs_test(test-web.cpp test-web LIBS LibWeb)
|
||||
|
@ -1,9 +1,12 @@
|
||||
file(GLOB CMD_SOURCES CONFIGURE_DEPENDS "*.cpp")
|
||||
set(TEST_SOURCES
|
||||
test-run-ls.cpp
|
||||
ue-write-oob.cpp
|
||||
)
|
||||
|
||||
# FIXME: These tests do not use LibTest
|
||||
foreach(CMD_SRC ${CMD_SOURCES})
|
||||
get_filename_component(CMD_NAME ${CMD_SRC} NAME_WE)
|
||||
add_executable(${CMD_NAME} ${CMD_SRC})
|
||||
target_link_libraries(${CMD_NAME} LibCore)
|
||||
install(TARGETS ${CMD_NAME} RUNTIME DESTINATION usr/Tests/UserEmulator)
|
||||
foreach(source IN LISTS TEST_SOURCES)
|
||||
get_filename_component(test_name "${source}" NAME_WE)
|
||||
add_executable("${test_name}" "${source}")
|
||||
target_link_libraries("${test_name}" LibCore)
|
||||
install(TARGETS "${test_name}" RUNTIME DESTINATION usr/Tests/UserEmulator)
|
||||
endforeach()
|
||||
|
Loading…
Reference in New Issue
Block a user