LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Libraries: Use default constructors/destructors in LibCpp

Browse Source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:30:59 -07:00 committed by Brian Gianforcaro
parent cb87d13dd5
commit 59b7e6a213
Notes: sideshowbarker 2024-07-17 17:33:57 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/59b7e6a213
Pull-request: https://github.com/SerenityOS/serenity/pull/12994
4 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibCpp/SemanticSyntaxHighlighter.h
View File

@ -18,7 +18,7 @@ namespace Cpp {
class SemanticSyntaxHighlighter final : public Syntax::Highlighter {
public:
SemanticSyntaxHighlighter() { }
SemanticSyntaxHighlighter() = default;
virtual ~SemanticSyntaxHighlighter() override = default;
virtual bool is_identifier(u64 token) const override;

6
Userland/Libraries/LibCpp/SyntaxHighlighter.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -98,8 +98,4 @@ bool SyntaxHighlighter::token_types_equal(u64 token1, u64 token2) const
return static_cast<Cpp::Token::Type>(token1) == static_cast<Cpp::Token::Type>(token2);
}
SyntaxHighlighter::~SyntaxHighlighter()
{
}
}

6
Userland/Libraries/LibCpp/SyntaxHighlighter.h
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -16,8 +16,8 @@ class SyntaxHighlighter final : public Syntax::Highlighter {
friend SemanticSyntaxHighlighter;
public:
SyntaxHighlighter() { }
virtual ~SyntaxHighlighter() override;
SyntaxHighlighter() = default;
virtual ~SyntaxHighlighter() override = default;
virtual bool is_identifier(u64) const override;
virtual bool is_navigatable(u64) const override;

1
Userland/Libraries/LibDesktop/AppFile.h
View File

@ -1,5 +1,6 @@
/*
* Copyright (c) 2020, Linus Groh <linusg@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/