LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-08-16 08:50:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use memcpy() in CanvasRenderingContext2D.getImageData()

Browse Source 
Instead of copying the image data pixel-by-pixel, we can memcpy full
scanlines at a time.

This knocks a 4% item down to <1% in profiles of Another World JS.
This commit is contained in:
Andreas Kling 2024-05-13 12:39:29 +02:00
parent 6f5201b759
commit 59cb7994c6
Notes: sideshowbarker 2024-07-17 04:03:27 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/59cb7994c6
Pull-request: https://github.com/SerenityOS/serenity/pull/24314
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/CanvasRenderingContext2D.cpp
View File

@ -407,10 +407,9 @@ WebIDL::ExceptionOr<JS::GCPtr<ImageData>> CanvasRenderingContext2D::get_image_da
// 6. Set the pixel values of imageData to be the pixels of this's output bitmap in the area specified by the source rectangle in the bitmap's coordinate space units, converted from this's color space to imageData's colorSpace using 'relative-colorimetric' rendering intent.
// FIXME: Can't use a Gfx::Painter + blit() here as it doesn't support ImageData bitmap's RGBA8888 format.
for (int target_y = 0; target_y < source_rect_intersected.height(); ++target_y) {
for (int target_x = 0; target_x < source_rect_intersected.width(); ++target_x) {
auto pixel = bitmap.get_pixel(target_x + x, target_y + y);
image_data->bitmap().set_pixel(target_x, target_y, pixel);
}
auto* dst = image_data->bitmap().scanline(target_y);
auto const* src = bitmap.scanline(target_y + y) + x;
memcpy(dst, src, source_rect_intersected.width() * sizeof(Gfx::ARGB32));
}
// 7. Set the pixels values of imageData for areas of the source rectangle that are outside of the output bitmap to transparent black.