LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-10-26 06:49:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/CSS: Treat counters() function with 1 argument as invalid

Browse Source 
Fixes #887.
This commit is contained in:
Sam Atkins 2024-07-29 16:20:36 +01:00 committed by Tim Flynn
parent 0bfcf73524
commit 5abe246385
Notes: github-actions[bot] 2024-07-29 16:58:37 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/5abe246385d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/890
Reviewed-by: https://github.com/trflynn89 ✅
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Tests/LibWeb/Layout/expected/css-counters/counters-function-single-argument.txt Normal file
View File

@ -0,0 +1,11 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x17 children: inline
frag 0 from TextNode start: 0, length: 19, rect: [8,8 162.109375x17] baseline: 13.296875
"PASS (didn't crash)"
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x600]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x17]
TextPaintable (TextNode<#text>)

5
Tests/LibWeb/Layout/input/css-counters/counters-function-single-argument.html Normal file
View File

@ -0,0 +1,5 @@
<style>
html {
content: counters(index);
}
</style>PASS (didn't crash)

2
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View File

@ -3003,7 +3003,7 @@ RefPtr<StyleValue> Parser::parse_counter_value(TokenStream<ComponentValue>& toke
auto& function = token.function();
TokenStream function_tokens { function.values() };
auto function_values = parse_a_comma_separated_list_of_component_values(function_tokens);
if (function_values.is_empty() || function_values.size() > 3)
if (function_values.size() < 2 || function_values.size() > 3)
return nullptr;
TokenStream name_tokens { function_values[0] };