LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-21 02:08:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

Browser: Show a message when attempting to search with no search engine

Browse Source 
Previously, it just showed an error message saying that "" failed to
load, which made me think that search engines were broken.
This commit is contained in:
Sam Atkins 2021-07-30 12:16:58 +01:00 committed by Andreas Kling
parent c88756078a
commit 5de7775d22
Notes: sideshowbarker 2024-07-18 07:44:50 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/5de7775d22b
Pull-request: https://github.com/SerenityOS/serenity/pull/9110
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Applications/Browser/Tab.cpp
View File

@ -21,6 +21,7 @@
#include <LibGUI/Button.h>
#include <LibGUI/Clipboard.h>
#include <LibGUI/Menu.h>
#include <LibGUI/MessageBox.h>
#include <LibGUI/Statusbar.h>
#include <LibGUI/TextBox.h>
#include <LibGUI/Toolbar.h>
@ -145,6 +146,11 @@ Tab::Tab(BrowserWindow& window, Type type)
m_location_box->set_placeholder("Address");
m_location_box->on_return_pressed = [this] {
if (m_location_box->text().starts_with('?') && g_search_engine.is_empty()) {
GUI::MessageBox::show(&this->window(), "Select a search engine in the Settings menu before searching.", "No search engine selected", GUI::MessageBox::Type::Information);
return;
}
auto url = url_from_user_input(m_location_box->text());
load(url);
view().set_focus(true);