LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-17 16:28:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibAudio: Remove the strong reference to the PulseAudio control thread

Browse Source 
Now that `Thread` keeps itself alive when it is running detached, we do
not need to hold onto it in the PulseAudio playback stream's internal
state object. This was a hack that did not work correctly because the
`Thread` object and its action `Function` would be deleted before the
action had exited and cause a crash.
This commit is contained in:
Zaggy1024 2023-08-06 01:35:24 -05:00 committed by Andrew Kaster
parent aff64b6a03
commit 5ea5ae85d2
Notes: sideshowbarker 2024-07-16 23:38:54 +09:00 
Author: https://github.com/Zaggy1024
Commit: https://github.com/SerenityOS/serenity/commit/5ea5ae85d2
Pull-request: https://github.com/SerenityOS/serenity/pull/20350
Reviewed-by: https://github.com/ADKaster ✅
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Userland/Libraries/LibAudio/PlaybackStreamPulseAudio.cpp
View File

@ -45,7 +45,6 @@ ErrorOr<NonnullRefPtr<PlaybackStream>> PlaybackStreamPulseAudio::create(OutputSt
},
"Audio::PlaybackStream"sv));
internal_state->set_thread(thread);
thread->start();
thread->detach();
return playback_stream;
@ -136,12 +135,6 @@ ErrorOr<void> PlaybackStreamPulseAudio::InternalState::check_is_running()
return {};
}
void PlaybackStreamPulseAudio::InternalState::set_thread(NonnullRefPtr<Threading::Thread> const& thread)
{
Threading::MutexLocker locker { m_mutex };
m_thread = thread;
}
void PlaybackStreamPulseAudio::InternalState::set_stream(NonnullRefPtr<PulseAudioStream> const& stream)
{
m_stream = stream;
@ -177,10 +170,6 @@ void PlaybackStreamPulseAudio::InternalState::thread_loop()
}
task();
}
// Stop holding onto our thread so it can be deleted.
Threading::MutexLocker locker { m_mutex };
m_thread = nullptr;
}
void PlaybackStreamPulseAudio::InternalState::exit()

4
Userland/Libraries/LibAudio/PlaybackStreamPulseAudio.h
View File

@ -31,8 +31,6 @@ private:
// the UI thread.
class InternalState : public AtomicRefCounted<InternalState> {
public:
void set_thread(NonnullRefPtr<Threading::Thread> const&);
void set_stream(NonnullRefPtr<PulseAudioStream> const&);
RefPtr<PulseAudioStream> stream();
@ -49,8 +47,6 @@ private:
Threading::ConditionVariable m_wake_condition { m_mutex };
Atomic<bool> m_exit { false };
RefPtr<Threading::Thread> m_thread { nullptr };
};
PlaybackStreamPulseAudio(NonnullRefPtr<InternalState>);