LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 09:49:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make factory method of DOM::AbortController fallible

Browse Source
This commit is contained in:
Kenneth Myhra 2023-02-14 20:45:54 +01:00 committed by Linus Groh
parent 491c18a346
commit 5f552ddc5c
Notes: sideshowbarker 2024-07-17 04:49:48 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/5f552ddc5c
Pull-request: https://github.com/SerenityOS/serenity/pull/17491
Reviewed-by: https://github.com/linusg ✅
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/AbortController.cpp
View File

@ -10,10 +10,10 @@
namespace Web::DOM {
JS::NonnullGCPtr<AbortController> AbortController::construct_impl(JS::Realm& realm)
WebIDL::ExceptionOr<JS::NonnullGCPtr<AbortController>> AbortController::construct_impl(JS::Realm& realm)
{
auto signal = AbortSignal::construct_impl(realm);
return realm.heap().allocate<AbortController>(realm, realm, move(signal)).release_allocated_value_but_fixme_should_propagate_errors();
return MUST_OR_THROW_OOM(realm.heap().allocate<AbortController>(realm, realm, move(signal)));
}
// https://dom.spec.whatwg.org/#dom-abortcontroller-abortcontroller

2
Userland/Libraries/LibWeb/DOM/AbortController.h
View File

@ -16,7 +16,7 @@ class AbortController final : public Bindings::PlatformObject {
WEB_PLATFORM_OBJECT(AbortController, Bindings::PlatformObject);
public:
static JS::NonnullGCPtr<AbortController> construct_impl(JS::Realm&);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<AbortController>> construct_impl(JS::Realm&);
virtual ~AbortController() override;