From 616b3dc718f82e23d562249e31090c9b95dbe26c Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Mon, 12 Sep 2022 21:02:11 +0200 Subject: [PATCH] Meta: Fix check for AK test inclusion basename from GNU coreutils 8.32 (the default on Debian Bullseye, as bash 5.2.0 does not include basename as a built-in command) does not accept multiple arguments. This will cause the command to fail with no output, and the error code not being propagated for some reason. This means that the loop never gets executed, and thus the check never actually does anything. This commit fixes that behavior by calling 'basename' multiple times. --- Meta/check-ak-test-files.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Meta/check-ak-test-files.sh b/Meta/check-ak-test-files.sh index 1a4b1b262a0..564c34ceb9e 100755 --- a/Meta/check-ak-test-files.sh +++ b/Meta/check-ak-test-files.sh @@ -14,7 +14,7 @@ while IFS= read -r FILENAME; do MISSING_FILES=y fi done < <( - git ls-files 'Tests/AK/Test*.cpp' | xargs basename + git ls-files 'Tests/AK/Test*.cpp' | xargs -n1 basename ) if [ "n" != "${MISSING_FILES}" ] ; then