LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-10-26 14:57:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Add updated version of "determine the origin" AO from HTML spec

Browse Source 
The old version is still around since it has many users, so we can't
remove it until everything has been updated to use the new version.
This commit is contained in:
Andreas Kling 2022-12-12 17:36:20 +01:00
parent 3225c39191
commit 65467021e2
Notes: sideshowbarker 2024-07-17 05:58:46 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/65467021e2
Pull-request: https://github.com/SerenityOS/serenity/pull/18478
2 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp
View File

@ -45,6 +45,7 @@ static bool url_matches_about_blank(AK::URL const& url)
&& url.host().is_null();
}
// FIXME: This is an outdated older version of "determining the origin" and should be removed.
// https://html.spec.whatwg.org/multipage/browsers.html#determining-the-origin
HTML::Origin determine_the_origin(BrowsingContext const& browsing_context, Optional<AK::URL> url, SandboxingFlagSet sandbox_flags, Optional<HTML::Origin> invocation_origin)
{
@ -73,6 +74,34 @@ HTML::Origin determine_the_origin(BrowsingContext const& browsing_context, Optio
return URL::url_origin(*url);
}
// https://html.spec.whatwg.org/multipage/document-sequences.html#determining-the-origin
HTML::Origin determine_the_origin(AK::URL const& url, SandboxingFlagSet sandbox_flags, Optional<HTML::Origin> source_origin, Optional<HTML::Origin> container_origin)
{
// 1. If sandboxFlags has its sandboxed origin browsing context flag set, then return a new opaque origin.
if (sandbox_flags.flags & SandboxingFlagSet::SandboxedOrigin) {
return HTML::Origin {};
}
// FIXME: 2. If url is null, then return a new opaque origin.
// FIXME: There appears to be no way to get a null URL here, so it might be a spec bug.
// 3. If url is about:srcdoc, then:
if (url == "about:srcdoc"sv) {
// 1. Assert: containerOrigin is non-null.
VERIFY(container_origin.has_value());
// 2. Return containerOrigin.
return container_origin.release_value();
}
// 4. If url matches about:blank and sourceOrigin is non-null, then return sourceOrigin.
if (url_matches_about_blank(url) && source_origin.has_value())
return source_origin.release_value();
// 5. Return url's origin.
return URL::url_origin(url);
}
// https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-top-level-browsing-context
JS::NonnullGCPtr<BrowsingContext> BrowsingContext::create_a_new_top_level_browsing_context(Web::Page& page)
{

3
Userland/Libraries/LibWeb/HTML/BrowsingContext.h
View File

@ -330,6 +330,9 @@ private:
bool m_has_been_discarded { false };
};
// FIXME: Remove this once everything is switched to the new overload.
HTML::Origin determine_the_origin(BrowsingContext const& browsing_context, Optional<AK::URL> url, SandboxingFlagSet sandbox_flags, Optional<HTML::Origin> invocation_origin);
HTML::Origin determine_the_origin(AK::URL const& url, SandboxingFlagSet sandbox_flags, Optional<HTML::Origin> source_origin, Optional<HTML::Origin> container_origin);
}