mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-11 05:25:32 +03:00
LibWeb: Append attributes to the correct element
The spec indicates we should append attributes to the top element of the stack of open elements. We were appending the attribute to the bottom.
This commit is contained in:
parent
9fe35ddddf
commit
657bbd1542
Notes:
github-actions[bot]
2024-07-30 07:42:32 +00:00
Author: https://github.com/trflynn89 Commit: https://github.com/LadybirdBrowser/ladybird/commit/657bbd1542c Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/894
@ -1 +1 @@
|
||||
PASS (didn't crash)
|
||||
HTML element has '<head' attribute: true
|
||||
|
@ -5,6 +5,6 @@
|
||||
<script src="include.js"></script>
|
||||
<script>
|
||||
test(() => {
|
||||
println("PASS (didn't crash)");
|
||||
println(`HTML element has '<head' attribute: ${document.documentElement.hasAttribute('<head')}`);
|
||||
});
|
||||
</script>
|
||||
|
@ -1719,9 +1719,10 @@ void HTMLParser::handle_in_body(HTMLToken& token)
|
||||
|
||||
// Otherwise, for each attribute on the token, check to see if the attribute is already present on the top element of the stack of open elements.
|
||||
// If it is not, add the attribute and its corresponding value to that element.
|
||||
auto& top_element = m_stack_of_open_elements.first();
|
||||
token.for_each_attribute([&](auto& attribute) {
|
||||
if (!current_node().has_attribute(attribute.local_name))
|
||||
current_node().append_attribute(attribute.local_name, attribute.value);
|
||||
if (!top_element.has_attribute(attribute.local_name))
|
||||
top_element.append_attribute(attribute.local_name, attribute.value);
|
||||
return IterationDecision::Continue;
|
||||
});
|
||||
return;
|
||||
|
Loading…
Reference in New Issue
Block a user