From 65b420f99699ce308b88a15b8144c76a2f682f50 Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Mon, 2 Jan 2023 16:57:12 +0100 Subject: [PATCH] Everywhere: Remove unused includes of AK/Memory.h These instances were detected by searching for files that include AK/Memory.h, but don't match the regex: \\b(fast_u32_copy|fast_u32_fill|secure_zero|timing_safe_compare)\\b This regex is pessimistic, so there might be more files that don't actually use any memory function. In theory, one might use LibCPP to detect things like this automatically, but let's do this one step after another. --- AK/DeprecatedString.cpp | 1 - AK/String.cpp | 1 - AK/StringImpl.cpp | 1 - AK/StringUtils.cpp | 1 - AK/StringView.cpp | 1 - Kernel/Arch/x86_64/ISABus/HID/PS2MouseDevice.cpp | 1 - Kernel/Arch/x86_64/Interrupts/APIC.cpp | 1 - Kernel/Devices/FullDevice.cpp | 1 - Kernel/Devices/MemoryDevice.cpp | 1 - Kernel/Devices/ZeroDevice.cpp | 1 - Kernel/FileSystem/InodeWatcher.cpp | 1 - Kernel/KBuffer.h | 1 - Kernel/Memory/MemoryManager.cpp | 1 - Kernel/Memory/PageDirectory.cpp | 1 - Kernel/Memory/Region.cpp | 1 - Kernel/Storage/StorageDevice.cpp | 1 - Userland/Libraries/LibELF/Image.cpp | 1 - 17 files changed, 17 deletions(-) diff --git a/AK/DeprecatedString.cpp b/AK/DeprecatedString.cpp index c2ff851ea66..a929824ea37 100644 --- a/AK/DeprecatedString.cpp +++ b/AK/DeprecatedString.cpp @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include diff --git a/AK/String.cpp b/AK/String.cpp index 8c9afb0aee5..2243968b3da 100644 --- a/AK/String.cpp +++ b/AK/String.cpp @@ -6,7 +6,6 @@ #include #include -#include #include #include #include diff --git a/AK/StringImpl.cpp b/AK/StringImpl.cpp index a5251521d97..76cc66e431f 100644 --- a/AK/StringImpl.cpp +++ b/AK/StringImpl.cpp @@ -7,7 +7,6 @@ #include #include #include -#include #include #include #include diff --git a/AK/StringUtils.cpp b/AK/StringUtils.cpp index bfa840bf813..5640be9109d 100644 --- a/AK/StringUtils.cpp +++ b/AK/StringUtils.cpp @@ -7,7 +7,6 @@ #include #include -#include #include #include #include diff --git a/AK/StringView.cpp b/AK/StringView.cpp index 92315f6add9..8d907e4d858 100644 --- a/AK/StringView.cpp +++ b/AK/StringView.cpp @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include diff --git a/Kernel/Arch/x86_64/ISABus/HID/PS2MouseDevice.cpp b/Kernel/Arch/x86_64/ISABus/HID/PS2MouseDevice.cpp index 72b73cbba00..a00f33948c5 100644 --- a/Kernel/Arch/x86_64/ISABus/HID/PS2MouseDevice.cpp +++ b/Kernel/Arch/x86_64/ISABus/HID/PS2MouseDevice.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/Arch/x86_64/Interrupts/APIC.cpp b/Kernel/Arch/x86_64/Interrupts/APIC.cpp index 262c6011c2f..c6bdc9a3faa 100644 --- a/Kernel/Arch/x86_64/Interrupts/APIC.cpp +++ b/Kernel/Arch/x86_64/Interrupts/APIC.cpp @@ -5,7 +5,6 @@ */ #include -#include #include #include #include diff --git a/Kernel/Devices/FullDevice.cpp b/Kernel/Devices/FullDevice.cpp index c4062a3801e..70e5ad83182 100644 --- a/Kernel/Devices/FullDevice.cpp +++ b/Kernel/Devices/FullDevice.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/Devices/MemoryDevice.cpp b/Kernel/Devices/MemoryDevice.cpp index 454bd28615a..9b0a06fd86a 100644 --- a/Kernel/Devices/MemoryDevice.cpp +++ b/Kernel/Devices/MemoryDevice.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/Devices/ZeroDevice.cpp b/Kernel/Devices/ZeroDevice.cpp index 21ea2c10e3a..df674c820e8 100644 --- a/Kernel/Devices/ZeroDevice.cpp +++ b/Kernel/Devices/ZeroDevice.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/FileSystem/InodeWatcher.cpp b/Kernel/FileSystem/InodeWatcher.cpp index 50f0f75b0c3..e30e2b4410e 100644 --- a/Kernel/FileSystem/InodeWatcher.cpp +++ b/Kernel/FileSystem/InodeWatcher.cpp @@ -5,7 +5,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/KBuffer.h b/Kernel/KBuffer.h index a9f2c1f1701..a3bf599820c 100644 --- a/Kernel/KBuffer.h +++ b/Kernel/KBuffer.h @@ -16,7 +16,6 @@ // severely limited kmalloc heap. #include -#include #include #include diff --git a/Kernel/Memory/MemoryManager.cpp b/Kernel/Memory/MemoryManager.cpp index a0d4af14c1b..154dba1f77c 100644 --- a/Kernel/Memory/MemoryManager.cpp +++ b/Kernel/Memory/MemoryManager.cpp @@ -5,7 +5,6 @@ */ #include -#include #include #include #include diff --git a/Kernel/Memory/PageDirectory.cpp b/Kernel/Memory/PageDirectory.cpp index af7018d8ef1..2299a73dca1 100644 --- a/Kernel/Memory/PageDirectory.cpp +++ b/Kernel/Memory/PageDirectory.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/Memory/Region.cpp b/Kernel/Memory/Region.cpp index 2c4d0f7ed26..898eb60b48f 100644 --- a/Kernel/Memory/Region.cpp +++ b/Kernel/Memory/Region.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Kernel/Storage/StorageDevice.cpp b/Kernel/Storage/StorageDevice.cpp index 485fa47a47f..6677794d7b3 100644 --- a/Kernel/Storage/StorageDevice.cpp +++ b/Kernel/Storage/StorageDevice.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include diff --git a/Userland/Libraries/LibELF/Image.cpp b/Userland/Libraries/LibELF/Image.cpp index 0a4dea5b45c..cc73528f614 100644 --- a/Userland/Libraries/LibELF/Image.cpp +++ b/Userland/Libraries/LibELF/Image.cpp @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include