LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-10 13:00:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibSQL: Don't interpret AK::Error codes as SQL error codes

Browse Source 
This makes error invocations such as Error::from_string_literal become
associated with a SQLErrorCode (typically 0, AmbiguousColumnName). The
result, when displayed to the user, is quite confusing, e.g.:

    Column name 'Heap()::write_block(): Oversized block' is ambiguous

Instead, just interpret these as internal errors, so the error message
is displayed as-is.
This commit is contained in:
Timothy Flynn 2023-01-25 17:57:06 -05:00 committed by Sam Atkins
parent 452285a3f8
commit 66f98237a7
Notes: sideshowbarker 2024-07-17 01:15:20 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/66f98237a7
Pull-request: https://github.com/SerenityOS/serenity/pull/17177
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibSQL/Result.h
View File

@ -94,7 +94,7 @@ public:
}
ALWAYS_INLINE Result(Error error)
: m_error(static_cast<SQLErrorCode>(error.code()))
: m_error(SQLErrorCode::InternalError)
, m_error_message(error.string_literal())
{
}