LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-01-08 20:32:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ext2FS: Make block list flushing a bit less aggressive

Browse Source 
We don't need to flush the on-disk inode struct multiple times while
writing out its block list. Just mark the in-memory Inode as having
dirty metadata and the SyncTask will flush it eventually.
This commit is contained in:
Andreas Kling 2021-02-26 18:24:40 +01:00
parent c3a0fd4b7a
commit 69a30f95cc
Notes: sideshowbarker 2024-07-18 21:54:08 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/69a30f95cc7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Kernel/FileSystem/Ext2FileSystem.cpp
View File

@ -237,7 +237,7 @@ KResult Ext2FSInode::flush_block_list()
if (m_block_list.is_empty()) {
m_raw_inode.i_blocks = 0;
memset(m_raw_inode.i_block, 0, sizeof(m_raw_inode.i_block));
fs().write_ext2_inode(index(), m_raw_inode);
set_metadata_dirty(true);
return KSuccess;
}
@ -274,7 +274,7 @@ KResult Ext2FSInode::flush_block_list()
for (size_t i = 0; i < min((size_t)EXT2_NDIR_BLOCKS, m_block_list.size()); ++i)
dbgln(" + {}", m_block_list[i]);
}
fs().write_ext2_inode(index(), m_raw_inode);
set_metadata_dirty(true);
inode_dirty = false;
}
@ -291,7 +291,7 @@ KResult Ext2FSInode::flush_block_list()
m_raw_inode.i_block[EXT2_IND_BLOCK] = new_indirect_block.value();
if (inode_dirty) {
dbgln_if(EXT2_DEBUG, "Ext2FS: Adding the indirect block to i_block array of inode {}", index());
fs().write_ext2_inode(index(), m_raw_inode);
set_metadata_dirty(true);
inode_dirty = false;
}
}
@ -331,7 +331,7 @@ KResult Ext2FSInode::flush_block_list()
m_raw_inode.i_block[EXT2_DIND_BLOCK] = new_dindirect_block.value();
if (inode_dirty) {
dbgln_if(EXT2_DEBUG, "Ext2FS: Adding the doubly-indirect block to i_block array of inode {}", index());
fs().write_ext2_inode(index(), m_raw_inode);
set_metadata_dirty(true);
inode_dirty = false;
}
}