mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-09-20 09:49:15 +03:00
LibWeb: Do not use OS error codes in the error callback for file:// URLs
The error code passed here is expected to be an HTTP error code. Passing errno codes does not make sense in that context.
This commit is contained in:
parent
ddb4137ed4
commit
69e8216f2c
Notes:
sideshowbarker
2024-07-17 08:34:29 +09:00
Author: https://github.com/trflynn89 Commit: https://github.com/SerenityOS/serenity/commit/69e8216f2c Pull-request: https://github.com/SerenityOS/serenity/pull/18181 Reviewed-by: https://github.com/linusg
@ -244,8 +244,10 @@ void ResourceLoader::load(LoadRequest& request, Function<void(ReadonlyBytes, Has
|
||||
|
||||
if (file_or_error.is_error()) {
|
||||
log_failure(request, file_or_error.error());
|
||||
if (error_callback)
|
||||
error_callback(DeprecatedString::formatted("{}", file_or_error.error()), file_or_error.error().code());
|
||||
if (error_callback) {
|
||||
auto status = file_or_error.error().code() == ENOENT ? 404u : 500u;
|
||||
error_callback(DeprecatedString::formatted("{}", file_or_error.error()), status);
|
||||
}
|
||||
return;
|
||||
}
|
||||
|
||||
@ -255,7 +257,7 @@ void ResourceLoader::load(LoadRequest& request, Function<void(ReadonlyBytes, Has
|
||||
if (maybe_file.is_error()) {
|
||||
log_failure(request, maybe_file.error());
|
||||
if (error_callback)
|
||||
error_callback(DeprecatedString::formatted("{}", maybe_file.error()), maybe_file.error().code());
|
||||
error_callback(DeprecatedString::formatted("{}", maybe_file.error()), 500u);
|
||||
return;
|
||||
}
|
||||
|
||||
@ -264,7 +266,7 @@ void ResourceLoader::load(LoadRequest& request, Function<void(ReadonlyBytes, Has
|
||||
if (maybe_data.is_error()) {
|
||||
log_failure(request, maybe_data.error());
|
||||
if (error_callback)
|
||||
error_callback(DeprecatedString::formatted("{}", maybe_data.error()), maybe_data.error().code());
|
||||
error_callback(DeprecatedString::formatted("{}", maybe_data.error()), 500u);
|
||||
return;
|
||||
}
|
||||
auto data = maybe_data.release_value();
|
||||
|
Loading…
Reference in New Issue
Block a user