LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-12-27 21:21:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Properly convert UnderlyingSource's autoAllocateChunkSize to u64

Browse Source 
The JS::Value being passed through is not a bigint, and needs to be
converted using ConvertToInt, as per:

https://webidl.spec.whatwg.org/#es-unsigned-long-long

Furthermore, the IDL definition also specifies that this is associated
with the [EnforceRange] extended attribute.

This makes it actually possible to pass through an autoAllocateChunkSize
to the ReadableStream constructor without it throwing a TypeError.
This commit is contained in:
Shannon Booth 2023-12-28 11:47:56 +13:00 committed by Andreas Kling
parent 99bf986889
commit 6b88fc2e05
Notes: sideshowbarker 2024-07-17 00:49:59 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/6b88fc2e05
Pull-request: https://github.com/SerenityOS/serenity/pull/22468
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/Streams/ReadableStream-autoAllocateChunkSize-constructor.txt Normal file
View File

@ -0,0 +1 @@
PASS. Made: ReadableStream

10
Tests/LibWeb/Text/input/Streams/ReadableStream-autoAllocateChunkSize-constructor.html Normal file
View File

@ -0,0 +1,10 @@
<script src="../include.js"></script>
<script>
test(() => {
let stream = new ReadableStream({
type: "bytes",
autoAllocateChunkSize: 64
});
println(`PASS. Made: ${stream.constructor.name}`);
});
</script>

9
Userland/Libraries/LibWeb/Streams/UnderlyingSource.cpp
View File

@ -1,5 +1,6 @@
/*
* Copyright (c) 2023, Matthew Olsson <mattco@serenityos.org>
* Copyright (c) 2023, Shannon Booth <shannon@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -7,7 +8,9 @@
#include <LibJS/Runtime/VM.h>
#include <LibWeb/Streams/AbstractOperations.h>
#include <LibWeb/Streams/UnderlyingSource.h>
#include <LibWeb/WebIDL/AbstractOperations.h>
#include <LibWeb/WebIDL/CallbackType.h>
#include <LibWeb/WebIDL/Types.h>
namespace Web::Streams {
@ -35,8 +38,10 @@ JS::ThrowCompletionOr<UnderlyingSource> UnderlyingSource::from_value(JS::VM& vm,
return vm.throw_completion<JS::TypeError>(ByteString::formatted("Unknown stream type '{}'", type_value));
}
if (TRY(object.has_property("autoAllocateChunkSize")))
underlying_source.auto_allocate_chunk_size = TRY(TRY(object.get("autoAllocateChunkSize")).to_bigint_uint64(vm));
if (TRY(object.has_property("autoAllocateChunkSize"))) {
auto value = TRY(object.get("autoAllocateChunkSize"));
underlying_source.auto_allocate_chunk_size = TRY(WebIDL::convert_to_int<WebIDL::UnsignedLongLong>(vm, value, WebIDL::EnforceRange::Yes));
}
return underlying_source;
}