LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-20 17:58:18 +03:00
Code Issues Packages Projects Releases Wiki Activity

Meta/Lagom: Make sure that libraries are always linked as PRIVATE

Browse Source
This commit is contained in:
Sam Atkins 2023-01-15 21:12:11 +00:00 committed by Linus Groh
parent a4c8353472
commit 71af0c296f
Notes: sideshowbarker 2024-07-17 06:35:16 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/71af0c296f
Pull-request: https://github.com/SerenityOS/serenity/pull/17043
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/nico
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Meta/Lagom/CMakeLists.txt
View File

@ -251,7 +251,7 @@ function(lagom_test source)
cmake_parse_arguments(LAGOM_TEST "" "WORKING_DIRECTORY" "LIBS" ${ARGN})
get_filename_component(name ${source} NAME_WE)
add_executable(${name} ${source})
target_link_libraries(${name} LibCore LibTest LibTestMain ${LAGOM_TEST_LIBS})
target_link_libraries(${name} PRIVATE LibCore LibTest LibTestMain ${LAGOM_TEST_LIBS})
add_test(
NAME ${name}
COMMAND ${name}
@ -562,7 +562,7 @@ if (BUILD_LAGOM)
foreach(source ${AK_TEST_SOURCES})
lagom_test(${source} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/AK)
endforeach()
target_link_libraries(TestString LibUnicode)
target_link_libraries(TestString PRIVATE LibUnicode)
# LibAudio
file(GLOB LIBAUDIO_TEST_SOURCES CONFIGURE_DEPENDS "../../Tests/LibAudio/*.cpp")