LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-19 09:17:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Port TextEncoder interface from DeprecatedString to String

Browse Source
This commit is contained in:
Shannon Booth 2023-09-06 16:10:23 +12:00 committed by Tim Flynn
parent 278061e8b9
commit 76449c21b2
Notes: sideshowbarker 2024-07-18 00:41:35 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/76449c21b2
Pull-request: https://github.com/SerenityOS/serenity/pull/20968
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Encoding/TextEncoder.cpp
View File

@ -31,7 +31,7 @@ void TextEncoder::initialize(JS::Realm& realm)
}
// https://encoding.spec.whatwg.org/#dom-textencoder-encode
JS::Uint8Array* TextEncoder::encode(DeprecatedString const& input) const
JS::Uint8Array* TextEncoder::encode(String const& input) const
{
// NOTE: The AK::DeprecatedString returned from PrimitiveString::string() is always UTF-8, regardless of the internal string type, so most of these steps are no-ops.
@ -43,16 +43,16 @@ JS::Uint8Array* TextEncoder::encode(DeprecatedString const& input) const
// 3. Assert: result is not an error.
// 4. If result is finished, then convert output into a byte sequence and return a Uint8Array object wrapping an ArrayBuffer containing output.
auto byte_buffer = input.to_byte_buffer();
auto byte_buffer = MUST(ByteBuffer::copy(input.bytes()));
auto array_length = byte_buffer.size();
auto array_buffer = JS::ArrayBuffer::create(realm(), move(byte_buffer));
return JS::Uint8Array::create(realm(), array_length, *array_buffer);
}
// https://encoding.spec.whatwg.org/#dom-textencoder-encoding
DeprecatedFlyString const& TextEncoder::encoding()
FlyString const& TextEncoder::encoding()
{
static DeprecatedFlyString encoding = "utf-8"sv;
static const FlyString encoding = "utf-8"_fly_string;
return encoding;
}

4
Userland/Libraries/LibWeb/Encoding/TextEncoder.h
View File

@ -24,9 +24,9 @@ public:
virtual ~TextEncoder() override;
JS::Uint8Array* encode(DeprecatedString const& input) const;
JS::Uint8Array* encode(String const& input) const;
static DeprecatedFlyString const& encoding();
static FlyString const& encoding();
protected:
// https://encoding.spec.whatwg.org/#dom-textencoder

2
Userland/Libraries/LibWeb/Encoding/TextEncoder.idl
View File

@ -1,4 +1,4 @@
[Exposed=(Window,Worker), UseDeprecatedAKString]
[Exposed=(Window,Worker)]
interface TextEncoder {
constructor();