LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 13:36:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Do not dereference empty Optional in ReadableStream::visit_edges

Browse Source 
There are quite a few steps between a ReadableStream being created and
its controller being set. If GC occurs between those points, we will
have an empty Optional in ReadableStream::visit_edges. Seen on YouTube.
This commit is contained in:
Timothy Flynn 2023-04-14 08:43:47 -04:00 committed by Linus Groh
parent 9be5dcfd89
commit 781287c1e3
Notes: sideshowbarker 2024-07-17 03:14:39 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/781287c1e3
Pull-request: https://github.com/SerenityOS/serenity/pull/18367
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Streams/ReadableStream.cpp
View File

@ -108,7 +108,8 @@ JS::ThrowCompletionOr<void> ReadableStream::initialize(JS::Realm& realm)
void ReadableStream::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
m_controller->visit([&](auto& controller) { visitor.visit(controller); });
if (m_controller.has_value())
m_controller->visit([&](auto& controller) { visitor.visit(controller); });
visitor.visit(m_stored_error);
visitor.visit(m_reader);
}