LadybirdBrowser/ladybird
1
1
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-09-11 05:25:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Implement HTMLMediaElement.addTextTrack

Browse Source 
Removes some noise from the console when browsing bbc.co.uk :^)
This commit is contained in:
Jamie Mansfield 2024-07-25 20:23:15 +01:00 committed by Andreas Kling
parent ff08c2f735
commit 793248aec9
Notes: github-actions[bot] 2024-07-26 07:31:07 +00:00 
Author: https://github.com/jamierocks
Commit: https://github.com/LadybirdBrowser/ladybird/commit/793248aec97
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/836
5 changed files with 61 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/HTML/HTMLMediaElement-addTextTrack.txt Normal file
View File

@ -0,0 +1,5 @@
track.kind: subtitles
track.label: demo label
track.language: en-GB
track.mode: hidden
addtrack event called

16
Tests/LibWeb/Text/input/HTML/HTMLMediaElement-addTextTrack.html Normal file
View File

@ -0,0 +1,16 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
const video = document.createElement("video");
video.textTracks.addEventListener("addtrack", () => {
println(`addtrack event called`);
});
const track = video.addTextTrack("subtitles", "demo label", "en-GB");
println(`track.kind: ${track.kind}`);
println(`track.label: ${track.label}`);
println(`track.language: ${track.language}`);
println(`track.mode: ${track.mode}`);
});
</script>

36
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@ -465,6 +465,42 @@ double HTMLMediaElement::effective_media_volume() const
return volume;
}
// https://html.spec.whatwg.org/multipage/media.html#dom-media-addtexttrack
JS::NonnullGCPtr<TextTrack> HTMLMediaElement::add_text_track(Bindings::TextTrackKind kind, String const& label, String const& language)
{
// 1. Create a new TextTrack object.
auto text_track = TextTrack::create(this->realm());
// 2. Create a new text track corresponding to the new object, and set its text track kind to kind, its text track
// label to label, its text track language to language, its text track readiness state to the text track loaded
// state, its text track mode to the text track hidden mode, and its text track list of cues to an empty list.
text_track->set_kind(kind);
text_track->set_label(label);
text_track->set_language(language);
text_track->set_readiness_state(TextTrack::ReadinessState::Loaded);
text_track->set_mode(Bindings::TextTrackMode::Hidden);
// FIXME: set text track list of cues to an empty list
// FIXME: 3. Initially, the text track list of cues is not associated with any rules for updating the text track rendering.
// When a text track cue is added to it, the text track list of cues has its rules permanently set accordingly.
// FIXME: 4. Add the new text track to the media element's list of text tracks.
// 5. Queue a media element task given the media element to fire an event named addtrack at the media element's
// textTracks attribute's TextTrackList object, using TrackEvent, with the track attribute initialized to the new
// text track's TextTrack object.
queue_a_media_element_task([this, text_track] {
TrackEventInit event_init {};
event_init.track = JS::make_handle(text_track);
auto event = TrackEvent::create(this->realm(), HTML::EventNames::addtrack, move(event_init));
m_text_tracks->dispatch_event(event);
});
// 6. Return the new TextTrack object.
return text_track;
}
// https://html.spec.whatwg.org/multipage/media.html#media-element-load-algorithm
WebIDL::ExceptionOr<void> HTMLMediaElement::load_element()
{

2
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.h
View File

@ -107,6 +107,8 @@ public:
JS::NonnullGCPtr<VideoTrackList> video_tracks() const { return *m_video_tracks; }
JS::NonnullGCPtr<TextTrackList> text_tracks() const { return *m_text_tracks; }
JS::NonnullGCPtr<TextTrack> add_text_track(Bindings::TextTrackKind kind, String const& label, String const& language);
WebIDL::ExceptionOr<void> handle_keydown(Badge<Web::EventHandler>, UIEvents::KeyCode);
enum class MouseTrackingComponent {

3
Userland/Libraries/LibWeb/HTML/HTMLMediaElement.idl
View File

@ -1,6 +1,7 @@
#import <HTML/AudioTrackList.idl>
#import <HTML/HTMLElement.idl>
#import <HTML/MediaError.idl>
#import <HTML/TextTrack.idl>
#import <HTML/TextTrackList.idl>
#import <HTML/TimeRanges.idl>
#import <HTML/VideoTrackList.idl>
@ -70,6 +71,6 @@ interface HTMLMediaElement : HTMLElement {
[SameObject] readonly attribute AudioTrackList audioTracks;
[SameObject] readonly attribute VideoTrackList videoTracks;
[SameObject] readonly attribute TextTrackList textTracks;
[FIXME] TextTrack addTextTrack(TextTrackKind kind, optional DOMString label = "", optional DOMString language = "");
TextTrack addTextTrack(TextTrackKind kind, optional DOMString label = "", optional DOMString language = "");
};